Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix type generation script #867

Merged
merged 1 commit into from
Jun 29, 2023
Merged

build: fix type generation script #867

merged 1 commit into from
Jun 29, 2023

Conversation

wolfy1339
Copy link
Member

Due to the recent changes to the tsconfig.json, type imports need to be marked as such, so that the compiler knows to strip it out from the output. By marking the type import, the script now runs correctly

Resolves #ISSUE_NUMBER


Behavior

Before the change?

  • The script would fail to run due to the json-schema module not being found

After the change?

  • The script now finishes without failing due to the type import of json-schema

Other information


Additional info

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Added the appropriate label for the given change

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes (Please add the Type: Breaking change label)
  • No

If Yes, what's the impact:

  • N/A

Pull request type

Please add the corresponding label for change this PR introduces:

  • Dependencies/code cleanup: Type: Maintenance

Due to the recent changes to the `tsconfig.json`, type imports need to be marked as such, so that the compiler knows to strip it out from the output.
By marking the type import, the script now runs correctly
@wolfy1339 wolfy1339 added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label Jun 29, 2023
@wolfy1339 wolfy1339 merged commit 97a4e03 into main Jun 29, 2023
@wolfy1339 wolfy1339 deleted the fix-update branch June 29, 2023 20:11
@github-actions
Copy link
Contributor

🎉 This PR is included in version 12.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants