Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP fix(types): transform method only accepts current event type #492

Closed
wants to merge 7 commits into from
Closed

WIP fix(types): transform method only accepts current event type #492

wants to merge 7 commits into from

Conversation

oscard0m
Copy link
Member

@oscard0m oscard0m commented Mar 12, 2021 •
edited
Loading

No description provided.

@oscard0m oscard0m added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label Mar 12, 2021
@oscard0m oscard0m marked this pull request as draft March 12, 2021 23:10
@oscard0m oscard0m force-pushed the transform-method-only-accepts-current-event-types branch from 2731aff to 12afb27 Compare March 12, 2021 23:12
@oscard0m oscard0m force-pushed the transform-method-only-accepts-current-event-types branch from 7d1d773 to fc8fded Compare March 12, 2021 23:25
@oscard0m oscard0m changed the title fix(types): transform method only accepts current event type WIP fix(types): transform method only accepts current event type Mar 13, 2021
@oscard0m oscard0m marked this pull request as ready for review March 13, 2021 00:21
oscard0m
oscard0m commented Mar 13, 2021
View reviewed changes
src/types.ts
Comment on lines +25 to +26
E extends EmitterWebhookEventName = any,
TTransformed extends EmitterWebhookEvent<E> = any
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to improve these any default values here. Is it possible?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can default to EmitterWebhookEventName, it's done elsewhere in the code

@oscard0m oscard0m mentioned this pull request Mar 13, 2021
Closed
@oscard0m oscard0m requested a review from wolfy1339 March 13, 2021 00:37
@wolfy1339
Copy link
Member

I tested your patch and it doesn't seem to fix the issue at hand

@wolfy1339
Copy link
Member

I think some next steps would be to check if reverting these PRs fixes the problem
#459 #464

@oscard0m
Copy link
Member Author

oscard0m commented Mar 14, 2021 •
edited
Loading

I think some next steps would be to check if reverting these PRs fixes the problem
#459 #464

Opened a new PR reverting these 2 PR commits: #494

Closing this one since it's not fixing the issue, as @wolfy1339 pointed

@oscard0m oscard0m mentioned this pull request Mar 14, 2021
Merged
@oscard0m oscard0m closed this Mar 14, 2021
@oscard0m oscard0m deleted the transform-method-only-accepts-current-event-types branch March 14, 2021 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolfy1339 wolfy1339 Awaiting requested review from wolfy1339

Assignees
No one assigned
Labels
Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oscard0m @wolfy1339