Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(typescript): new deployment object for CheckRunEvent; cleanup properties in issue and pull_request events; fix GitHubOrg interface values #478

Merged
merged 6 commits into from
Mar 2, 2021

Conversation

octokitbot
Copy link
Collaborator

A new release of @octokit/webhooks was just released 👋🤖

This pull request updates the TypeScript definitions derived from @octokit/webhooks. I can't tell if the changes are fixes, features or breaking, you'll have to figure that out on yourself and adapt the commit messages accordingly to trigger the right release, see our commit message conventions.

@octokitbot octokitbot added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label Feb 19, 2021
@wolfy1339 wolfy1339 changed the title 🚧 🤖📯 Webhooks changed feat(typescript): new deployment object for CheckRunEvent Feb 24, 2021
@wolfy1339
Copy link
Member

wolfy1339 commented Feb 24, 2021

I just noticed an inconsistency in the Webhooks docs between the example payload for the CheckRunEvent and the properties table.
In the example payload the new deployment object is in the check_run object of the payload, but according to the properties table, it should not be contained in any other object.

EDIT: The payload example was confirmed as correct github/docs#3962 (comment)

@wolfy1339 wolfy1339 changed the title feat(typescript): new deployment object for CheckRunEvent 🚧 feat(typescript): new deployment object for CheckRunEvent Feb 24, 2021
@wolfy1339 wolfy1339 changed the title 🚧 feat(typescript): new deployment object for CheckRunEvent 🚧 feat(typescript): new deployment object for CheckRunEvent; cleanup properties in issue and pull_request events; fix GitHubOrg interface values Feb 26, 2021
@wolfy1339 wolfy1339 changed the title 🚧 feat(typescript): new deployment object for CheckRunEvent; cleanup properties in issue and pull_request events; fix GitHubOrg interface values feat(typescript): new deployment object for CheckRunEvent; cleanup properties in issue and pull_request events; fix GitHubOrg interface values Mar 2, 2021
@wolfy1339 wolfy1339 merged commit 639896f into master Mar 2, 2021
@wolfy1339 wolfy1339 deleted the update-octokit-webhooks branch March 2, 2021 00:56
@github-actions
Copy link
Contributor

github-actions bot commented Mar 2, 2021

🎉 This PR is included in version 8.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants