Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): downgrade sort-keys to v4 #497

Merged
merged 1 commit into from
Jan 19, 2023
Merged

Conversation

wolfy1339
Copy link
Member

The sort-keys dependency switched to ESM and is thus incompatible

Resolves #496


Behavior

Before the change?

  • The automated updates workflows was failing

After the change?

  • The automated update workflow should now run properly

Other information


Additional info

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Added the appropriate label for the given change

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes (Please add the Type: Breaking change label)
  • No

If Yes, what's the impact:

  • N/A

Pull request type

Please add the corresponding label for change this PR introduces:

  • Bugfix: Type: Bug
  • Feature/model/API additions: Type: Feature
  • Updates to docs or samples: Type: Documentation
  • Dependencies/code cleanup: Type: Maintenance

The `sort-keys` dependency switched to ESM and is thus incompatible

Fixes #496
@wolfy1339 wolfy1339 added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label Jan 19, 2023
@wolfy1339 wolfy1339 requested a review from kfcampbell January 19, 2023 23:29
Copy link
Member

@kfcampbell kfcampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for bearing with me as I stumble my way through learning this process.

@wolfy1339 wolfy1339 merged commit abc85b6 into main Jan 19, 2023
@wolfy1339 wolfy1339 deleted the downgrade-sort-keys branch January 19, 2023 23:37
@octokitbot
Copy link
Collaborator

🎉 This PR is included in version 8.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@octokitbot
Copy link
Collaborator

🎉 This PR is included in version 8.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released on @8.x released Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[MAINT]: Automated update failing
3 participants