actually fix regression with updating issue labels #718
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #715
When you update an issue, the value in
Labels
is important. From the docs:There's three scenarios we need to support here, and I think this is the best compromise:
.ToUpdate()
to setup your update request - this gives you anull
collection of branches, which means you're not changing anything server-side.AddLabel
manages the internal state of the list - and give you a collection which will replace whatever is currently thereClearLabels
should give you an empty collection - if this is used, it'll drop whatever labels you have defined on the server.How does that feel @thedillonb @haacked?