-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make GetAllContributors return a custom dto #614
Conversation
@@ -22,7 +22,7 @@ internal string DebuggerDisplay | |||
get | |||
{ | |||
return String.Format(CultureInfo.InvariantCulture, | |||
"Author: Id: {0} Login: {1}", Author.Id, Author.Login); | |||
"Contributor Statistics: Id: {0} Login: {1}", Author.Id, Author.Login); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the Statistics
step here a refactoring typo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
Re: naming things, I can see the documentation refers to https://developer.github.com/v3/repos/collaborators/ But on the website they're called https://github.com/octokit/octokit.net/graphs/contributors In An Ideal World, I'd like the names of our things to reflect the API directly, but I'm happy to take |
@@ -46,7 +46,7 @@ public class Author | |||
|
|||
public bool SiteAdmin { get; set; } | |||
|
|||
internal string DebuggerDisplay | |||
internal virtual string DebuggerDisplay |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any particular reason to virtual
-ize these? Should we be doing it for all of them?
A couple of little polish things - the rest look good ✨ |
@shiftkey ok i think i have addressed all your concerns. I also squashed |
Any timeline on the release this might be included in. Just wondering if I can delay my usage so I can just run with the proper nuget |
I'd like to get
|
make GetAllContributors return a custom dto
I see this was merged in to master and v0.5.3 was released, but I'm not seeing these changes in the v0.5.3 NuGet package. Was it somehow withheld from the release? |
@mkchandler my apologies, it didn't make it into 0.5.3 - https://github.com/octokit/octokit.net/releases/tag/v0.5.3 It'll be out in 0.6.0 along with some other fixes - #621 |
Sounds good 👍 Thanks |
fixes #610