added WPA81 to the list of PCL targets #575
Conversation
|
Cool - will this also ensure the NuGet package gets correctly generated? (i.e. the |
|
Based on the contents of Octokit.nuspec it looks like the supported frameworks stuff is being derived by nuget.exe but ive never used the implicit stuff to determine frameworks before so i don't really know if there is something hidden elsewhere. Edit: build.fsx is what determines the nuget package construction i will modify the PR with this once the NSubstitute failure is figured out. |
|
I'm not sure i understand the build failure that is present here, how has the addition of wpa81 to the pcl targets caused NSubstitute to not exist in the tests (for all of the test projects)? |
Not sure, this may be unrelated |
|
The NSubstitute thing is unrelated, fixing it over here #572 |
| @@ -2,7 +2,7 @@ | |||
| <Project ToolsVersion="12.0" DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003"> | |||
| <Import Project="$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props" Condition="Exists('$(MSBuildExtensionsPath)\$(MSBuildToolsVersion)\Microsoft.Common.props')" /> | |||
| <PropertyGroup> | |||
| <MinimumVisualStudioVersion>11.0</MinimumVisualStudioVersion> | |||
| <MinimumVisualStudioVersion>10.0</MinimumVisualStudioVersion> | |||
There was a problem hiding this comment.
We don't need this change. 🔥 it.
There was a problem hiding this comment.
the PCL retargeting dialog adds that rather intentionally when targeting wpa81, wp81 or win81,
There was a problem hiding this comment.
Not sure why it'd target an older version, but we can't support VS2012 or lower due to a WONTFIX issue with PCL + CodeAnalysis...
|
Is anything else required here? |
added WPA81 to the list of PCL targets
|
Nope. Thanks @hippiehunter! |
this is to solve #574