Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

started user keys support #525

Merged
merged 7 commits into from
Jul 10, 2014
Merged

started user keys support #525

merged 7 commits into from
Jul 10, 2014

Conversation

shiftkey
Copy link
Member

@shiftkey shiftkey commented Jul 8, 2014

@hnrkndrssn hnrkndrssn mentioned this pull request Jul 8, 2014
6 tasks

namespace Octokit
{
public static partial class ApiUrls
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ApiUrls has become a big class with everything intermixed. Moving forward, I think we should break it out so that things are easier to navigate.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. What did you have in mind?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As part of code reviews, if you're modifying/adding URLs - move it out to a separate partial class.

@haacked
Copy link
Contributor

haacked commented Jul 8, 2014

Whoops, can't merge it.

@shiftkey
Copy link
Member Author

shiftkey commented Jul 9, 2014

🐒

@shiftkey
Copy link
Member Author

download

shiftkey added a commit that referenced this pull request Jul 10, 2014
@shiftkey shiftkey merged commit 36261e8 into master Jul 10, 2014
@shiftkey shiftkey deleted the shiftkey/user-keys-client branch July 10, 2014 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants