Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #450 #451

Merged
merged 2 commits into from
Apr 16, 2014
Merged

Fix #450 #451

merged 2 commits into from
Apr 16, 2014

Conversation

kzu
Copy link
Contributor

@kzu kzu commented Apr 8, 2014

Remove redundant "Team" suffix from ITeamsClient methods.

Fixes #450

Remove redundant "Team" suffix from ITeamsClient methods.
@shiftkey
Copy link
Member

shiftkey commented Apr 8, 2014

IObservableTeamsClient and ObservableTeamsClient need to be updated to also drop the Team prefix from their methods.

Aside from that this is looking 💎 💎 💎

@kzu
Copy link
Contributor Author

kzu commented Apr 8, 2014

Done! :)

haacked added a commit that referenced this pull request Apr 16, 2014
@haacked haacked merged commit 7d112dd into octokit:master Apr 16, 2014
@haacked
Copy link
Contributor

haacked commented Apr 16, 2014


Thanks @kzu!

@kzu
Copy link
Contributor Author

kzu commented Apr 16, 2014

Hehe, you're welcome. I'll work more on the team client since I need all the functionality of the underlying github API, a lot of which is missing currently. Hopefully I'll find the time sooner than later :)

@kzu kzu deleted the SimplifyTeamClient branch April 16, 2014 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ITeamClient has redundant "Team" suffix in all methods
3 participants