Implemented Get / IsMember for teams #449
Conversation
| @@ -9,6 +10,7 @@ public static class Helper | |||
| { | |||
| var githubUsername = Environment.GetEnvironmentVariable("OCTOKIT_GITHUBUSERNAME"); | |||
| UserName = githubUsername; | |||
| Organization = Environment.GetEnvironmentVariable("OCTOKIT_GITHUBORGANIZATION"); | |||
There was a problem hiding this comment.
Can you update the CONTRIBUTING.md docs to include this new field? Also, do you want to support running both user and org tests in the same context?
There was a problem hiding this comment.
I think so. Even for organization tests, you always needs a valid user with ownership of the org.
Team tests don't work for users since it appears only orgs can own teams (just realized of this because I got errors trying with a user, and it's not doable on the website either)
There was a problem hiding this comment.
CONTRIBUTING.md doc updated!
|
Ack, there are conflicts so I can't merge this yet. |
Issue octokit#331. Added integration tests and a new attribute that requires a new environment variable with an organization to test. Conflicts: Octokit.Tests.Integration/Octokit.Tests.Integration.csproj
|
Rebased and fixed remaining conflicts. I need this merge so that I can continue working on the rest of Teams API ;) |
|
don't merge yet. got a build error |
|
Now it's ready :) |
|
@kzu would you mind adding the corresponding new methods to |
|
Done :) Just noticed how the CI works :) Also added missing null checks |
|
The CI is manually launched for now since we want don't want to run arbitrary third party code automatically. 😄 |
|
The failure seems unrelated to these changes. |
|
|
Implemented Get / IsMember for teams
Issue #331.
Added integration tests and a new attribute that requires a new environment variable with an organization to test.