Accepts parameter for Patch

[nigel-sampson]

This is a bit of a weird pull request, the app I'm building has Markdown support, so I'm using the underlying ApiConnection class to make use of Octokit, but with a custom accepts header. For instance:

public static Task<FullIssue> CreateFullIssueAsync(this IGitHubClient gitHubClient, string owner, string name, NewIssue issue)
{
    var uri = ApiUrls.Issues(owner, name);

    var apiConnection = new ApiConnection(gitHubClient.Connection);

    return apiConnection.Post<FullIssue>(uri, issue, "application/vnd.github.v3.full+json; charset=utf-8");
}

public class FullIssue : Issue
{
    public string BodyText
    {
        get; set;
    }

    public string BodyHtml
    {
        get; set;
    }
}

However some of the methods don't have overloads that take an accepts parameter. This will add them.

[shiftkey]

Am I understanding this right - you're posting to a custom API with this FullIssue entity, which is then propagated onto the GitHub API? With the Markdown and the rendered HTML?

[nigel-sampson]

No, I'm posting to the GitHub API directly. By changing the accepts header I can post the markdown, and when getting issues get both the markdown and html in one request.

In the above code I'm making use of the Octokit connection and parsing etc but need to send the custom accepts header.

However some of the underlying methods for Patch and Get don't expose an overload that takes accepts.

[shiftkey]

Right, I misread the context. My bad.

This all seems rather legit. Is it worth throwing any tests into the mix?

[nigel-sampson]

Done :-)