-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SearchRepo should return POCO instead of collection #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 5, 2014
Removed |
This was referenced Mar 5, 2014
@@ -32,7 +32,7 @@ | |||
<Optimize>true</Optimize> | |||
<IntermediateOutputPath>obj\Release\Net40</IntermediateOutputPath> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Heh, I just noticed our intermediate path is still Net40. Doesn't matter, but it's odd. 😄
haacked
added a commit
that referenced
this pull request
Mar 5, 2014
…ucture SearchRepo should return POCO instead of collection
Nice work @shiftkey! |
Whoops, forgot to choose an emoji. 🌠 ✌️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of resolving #411 we need to do a bit of work to deserialize things properly.
This is what we get from the server:
I thought about whether we could bypass all this and check for the presence of
items
in the JSON - perhaps we don't care abouttotal_count
- but the magic for that is deep insideConnection
.This PR fixes the
SearchRepo
method the user has report, but the other search methods need to be addressed as well.Fixes #411