Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SearchRepo should return POCO instead of collection #412

Merged
merged 9 commits into from
Mar 5, 2014

Conversation

shiftkey
Copy link
Member

@shiftkey shiftkey commented Mar 4, 2014

As part of resolving #411 we need to do a bit of work to deserialize things properly.

This is what we get from the server:

{
  "total_count": 40,
  "items": [
    {

    }
  ]
}

I thought about whether we could bypass all this and check for the presence of items in the JSON - perhaps we don't care about total_count - but the magic for that is deep inside Connection.

This PR fixes the SearchRepo method the user has report, but the other search methods need to be addressed as well.

  • add integration test and fix problem
  • update impacted tests
  • we should return a read-only collection - this isn't working in SimpleJson (how are we doing with updating that @haacked?)

Fixes #411

@shiftkey
Copy link
Member Author

shiftkey commented Mar 5, 2014

Removed [WIP] tag, ready for review

@@ -32,7 +32,7 @@
<Optimize>true</Optimize>
<IntermediateOutputPath>obj\Release\Net40</IntermediateOutputPath>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heh, I just noticed our intermediate path is still Net40. Doesn't matter, but it's odd. 😄

haacked added a commit that referenced this pull request Mar 5, 2014
…ucture

SearchRepo should return POCO instead of collection
@haacked haacked merged commit 1408730 into master Mar 5, 2014
@haacked haacked deleted the shiftkey/return-correct-data-structure branch March 5, 2014 19:09
@haacked
Copy link
Contributor

haacked commented Mar 5, 2014

Nice work @shiftkey!

@haacked
Copy link
Contributor

haacked commented Mar 5, 2014

Whoops, forgot to choose an emoji. 🌠 ✌️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repositories search just does not work
2 participants