Implement RepositoryExistsException #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -53,7 +60,7 @@ public override string Message | |||
|
|
|||
| public ApiError ApiError { get; private set; } | |||
|
|
|||
| static ApiError GetApiErrorFromExceptionMessage(IResponse response) | |||
| internal static ApiError GetApiErrorFromExceptionMessage(IResponse response) | |||
There was a problem hiding this comment.
Ignore this change. This was a different road I was planning to take, but decided against. I'll revert it.
|
Doh! I'll add these files. |
I don't think this can be improved on. It's perfection. |
This exception is thrown when we try to create a repository but it already exists on the server.
|
|
shiftkey
added a commit
that referenced
this pull request
Feb 19, 2014
…ions Implement RepositoryExistsException
|
From an API perspective, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exception is thrown when we try to create a repository but it
already exists on the server.
Wanted to get some eyes on this early. This is ready to merge. I plan to take the same approach for:
OverPrivateRepositoryQuotaExceptionCannotCreatePrivateRepositoryOnFreePlanException(not sure this is doable in Octokit.net yet).^^^ I could use help naming those better. :)