Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing issue event types #2024

Merged
merged 2 commits into from
Oct 8, 2019

Conversation

hnrkndrssn
Copy link
Contributor

@hnrkndrssn hnrkndrssn commented Oct 4, 2019

Fixes #2023
Fixes #2025

@codecov
Copy link

codecov bot commented Oct 4, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@3e7c70c). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #2024   +/-   ##
=========================================
  Coverage          ?   70.77%           
=========================================
  Files             ?      535           
  Lines             ?    14063           
  Branches          ?        0           
=========================================
  Hits              ?     9953           
  Misses            ?     4110           
  Partials          ?        0
Impacted Files Coverage Δ
Octokit/Models/Response/EventInfo.cs 9.09% <ø> (ø)

@shiftkey
Copy link
Member

shiftkey commented Oct 4, 2019

@hnrkndrssn thanks for opening this up!

@terrajobst are you able to verify this version fixes the issue for you?

Uploading artifacts...
[1/2] packaging\Octokit.0.36.0-PullRequest2024-0003.nupkg (1,953,185 bytes)...100%
[2/2] packaging\Octokit.Reactive.0.36.0-PullRequest2024-0003.nupkg (571,911 bytes)...100%

@terrajobst
Copy link

terrajobst commented Oct 5, 2019

I can do this tomorrow b/c I'll have to wait until my API rate limit is back. Unfortunately, I also talk to YouTube and that doesn't resent in one hour, it's a 24 hour rate :-(

@hnrkndrssn hnrkndrssn changed the title Add 'transferred' event type Add missing issue event types Oct 5, 2019
@shiftkey shiftkey merged commit 311e89a into octokit:master Oct 8, 2019
@shiftkey
Copy link
Member

shiftkey commented Oct 8, 2019

release_notes: added new event payload fields for head_ref_force_pushed and transferred

@nickfloyd nickfloyd added Type: Bug Something isn't working as documented and removed category: bug labels Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working as documented
Projects
None yet
4 participants