Adding initial support for GitHub Apps.

.travis.yml

@@ -7,13 +7,12 @@ matrix:
       sudo: required
       dotnet: 1.0.4
     - os: osx
-      osx_image: xcode8
+      osx_image: xcode8.3
       dotnet: 1.0.4
 
 before_script:
   - if test "$TRAVIS_OS_NAME" == "osx"; then export FrameworkPathOverride=/Library/Frameworks/Mono.framework/Versions/Current/lib/mono/4.5/; else export FrameworkPathOverride=/usr/lib/mono/4.5/; fi
 
 script:
   - git fetch --unshallow --tags
-  - dotnet --info
-  - ./build.sh --linksources=true
+  - ./build.sh --linksources=true --verbosity=verbose

Octokit.Reactive/Clients/IObservableGitHubAppsClient.cs

@@ -0,0 +1,57 @@
+using System;
+
+namespace Octokit.Reactive
+{
+    /// <summary>
+    /// A client for GitHub Applications API. Provides the methods required to get GitHub applications and installations.
+    /// </summary>
+    /// <remarks>
+    /// See the <a href="http://developer.github.com/v3/apps/">GitHub Apps API documentation</a> for more information.
+    /// </remarks>
+    public interface IObservableGitHubAppsClient
+    {
+        /// <summary>
+        /// Get a single GitHub App.
+        /// </summary>
+        /// <remarks>https://developer.github.com/v3/apps/#get-a-single-github-app</remarks>
+        /// <param name="slug">The URL-friendly name of your GitHub App. You can find this on the settings page for your GitHub App.</param>
+        IObservable<GitHubApp> Get(string slug);
+
+        /// <summary>
+        /// Returns the GitHub App associated with the authentication credentials used (requires GitHubApp JWT token auth).
+        /// </summary>
+        /// <remarks>https://developer.github.com/v3/apps/#get-the-authenticated-github-app</remarks>
+        IObservable<GitHubApp> GetCurrent();
+
+        /// <summary>
+        /// List installations of the authenticated GitHub App (requires GitHubApp JWT token auth).
+        /// </summary>
+        /// <remarks>https://developer.github.com/v3/apps/#find-installations</remarks>
+        IObservable<Installation> GetAllInstallationsForCurrent();
+
+        /// <summary>
+        /// List installations of the authenticated GitHub App (requires GitHubApp JWT token auth).
+        /// </summary>
+        /// <param name="options">Options for changing the API response</param>
+        /// <remarks>https://developer.github.com/v3/apps/#find-installations</remarks>
+        IObservable<Installation> GetAllInstallationsForCurrent(ApiOptions options);
+
+        /// <summary>
+        /// Get a single GitHub App Installation (requires GitHubApp JWT token auth).
+        /// </summary>
+        /// <remarks>https://developer.github.com/v3/apps/#get-a-single-installation</remarks>
+        /// <param name="installationId">The Id of the GitHub App Installation</param>
+        IObservable<Installation> GetInstallation(long installationId);
+
+        /// <summary>
+        /// Create a time bound access token for a GitHubApp Installation that can be used to access other API endpoints (requires GitHubApp JWT token auth).
+        /// </summary>
+        /// <remarks>
+        /// https://developer.github.com/v3/apps/#create-a-new-installation-token
+        /// https://developer.github.com/apps/building-github-apps/authentication-options-for-github-apps/#authenticating-as-an-installation
+        /// https://developer.github.com/v3/apps/available-endpoints/
+        /// </remarks>
+        /// <param name="installationId">The Id of the GitHub App Installation</param>
+        IObservable<AccessToken> CreateInstallationToken(long installationId);
+    }
+}

Octokit.Reactive/Clients/ObservableGitHubAppsClient.cs

@@ -0,0 +1,85 @@
+using Octokit.Reactive.Internal;
+using System;
+using System.Reactive.Threading.Tasks;
+
+namespace Octokit.Reactive
+{
+    /// <summary>
+    /// A client for GitHub Applications API. Provides the methods required to get GitHub applications and installations.
+    /// </summary>
+    /// <remarks>
+    /// See the <a href="http://developer.github.com/v3/apps/">GitHub Apps API documentation</a> for more information.
+    /// </remarks>
+    public class ObservableGitHubAppsClient : IObservableGitHubAppsClient
+    {
+        private IGitHubAppsClient _client;
+        private readonly IConnection _connection;
+
+        public ObservableGitHubAppsClient(IGitHubClient client)
+        {
+            Ensure.ArgumentNotNull(client, "client");
+
+            _client = client.GitHubApps;
+            _connection = client.Connection;
+        }
+
+        public IObservable<GitHubApp> Get(string slug)
+        {
+            return _client.Get(slug).ToObservable();
+        }
+
+        /// <summary>
+        /// Returns the GitHub App associated with the authentication credentials used (requires GitHubApp JWT token auth).
+        /// </summary>
+        /// <remarks>https://developer.github.com/v3/apps/#get-the-authenticated-github-app</remarks>
+        public IObservable<GitHubApp> GetCurrent()
+        {
+            return _client.GetCurrent().ToObservable();
+        }
+
+        /// <summary>
+        /// List installations of the authenticated GitHub App (requires GitHubApp JWT token auth).
+        /// </summary>
+        /// <remarks>https://developer.github.com/v3/apps/#find-installations</remarks>
+        public IObservable<Installation> GetAllInstallationsForCurrent()
+        {
+            return _connection.GetAndFlattenAllPages<Installation>(ApiUrls.Installations(), null, AcceptHeaders.GitHubAppsPreview);
+        }
+
+        /// <summary>
+        /// List installations of the authenticated GitHub App (requires GitHubApp JWT token auth).
+        /// </summary>
+        /// <param name="options">Options for changing the API response</param>
+        /// <remarks>https://developer.github.com/v3/apps/#find-installations</remarks>
+        public IObservable<Installation> GetAllInstallationsForCurrent(ApiOptions options)
+        {
+            Ensure.ArgumentNotNull(options, nameof(options));
+
+            return _connection.GetAndFlattenAllPages<Installation>(ApiUrls.Installations(), null, AcceptHeaders.GitHubAppsPreview, options);
+        }
+
+        /// <summary>
+        /// Get a single GitHub App Installation (requires GitHubApp JWT token auth).
+        /// </summary>
+        /// <remarks>https://developer.github.com/v3/apps/#get-a-single-installation</remarks>
+        /// <param name="installationId">The Id of the GitHub App Installation</param>
+        public IObservable<Installation> GetInstallation(long installationId)
+        {
+            return _client.GetInstallation(installationId).ToObservable();
+        }
+
+        /// <summary>
+        /// Create a time bound access token for a GitHubApp Installation that can be used to access other API endpoints (requires GitHubApp JWT token auth).
+        /// </summary>
+        /// <remarks>
+        /// https://developer.github.com/v3/apps/#create-a-new-installation-token
+        /// https://developer.github.com/apps/building-github-apps/authentication-options-for-github-apps/#authenticating-as-an-installation
+        /// https://developer.github.com/v3/apps/available-endpoints/
+        /// </remarks>
+        /// <param name="installationId">The Id of the GitHub App Installation</param>
+        public IObservable<AccessToken> CreateInstallationToken(long installationId)
+        {
+            return _client.CreateInstallationToken(installationId).ToObservable();
+        }
+    }
+}

Octokit.Reactive/IObservableGitHubClient.cs

@@ -18,6 +18,7 @@ public interface IObservableGitHubClient : IApiInfoProvider
 
         IObservableAuthorizationsClient Authorization { get; }
         IObservableActivitiesClient Activity { get; }
+        IObservableGitHubAppsClient GitHubApps { get; }
         IObservableIssuesClient Issue { get; }
         IObservableMiscellaneousClient Miscellaneous { get; }
         IObservableOauthClient Oauth { get; }

Octokit.Reactive/ObservableGitHubClient.cs

@@ -33,6 +33,7 @@ public ObservableGitHubClient(IGitHubClient gitHubClient)
             _gitHubClient = gitHubClient;
             Authorization = new ObservableAuthorizationsClient(gitHubClient);
             Activity = new ObservableActivitiesClient(gitHubClient);
+            GitHubApps = new ObservableGitHubAppsClient(gitHubClient);
             Issue = new ObservableIssuesClient(gitHubClient);
             Miscellaneous = new ObservableMiscellaneousClient(gitHubClient);
             Oauth = new ObservableOauthClient(gitHubClient);
@@ -69,6 +70,7 @@ public void SetRequestTimeout(TimeSpan timeout)
 
         public IObservableAuthorizationsClient Authorization { get; private set; }
         public IObservableActivitiesClient Activity { get; private set; }
+        public IObservableGitHubAppsClient GitHubApps { get; private set; }
         public IObservableIssuesClient Issue { get; private set; }
         public IObservableMiscellaneousClient Miscellaneous { get; private set; }
         public IObservableOauthClient Oauth { get; private set; }

Octokit.Reactive/Octokit.Reactive.csproj

@@ -33,17 +33,14 @@
 
   <ItemGroup>
     <PackageReference Include="System.Reactive" Version="3.1.0" />
+    <PackageReference Include="SourceLink.Create.GitHub" Version="2.8.0" />
+    <DotNetCliToolReference Include="dotnet-sourcelink-git" Version="2.8.0" />
+    <DotNetCliToolReference Include="dotnet-sourcelink" Version="2.8.0" />
   </ItemGroup>
 
   <ItemGroup Condition=" '$(TargetFramework)' == 'net45' ">
     <Reference Include="System" />
     <Reference Include="Microsoft.CSharp" />
   </ItemGroup>
 
-  <ItemGroup>
-    <PackageReference Include="SourceLink.Create.GitHub" Version="2.1.0" PrivateAssets="All" />
-    <DotNetCliToolReference Include="dotnet-sourcelink-git" Version="2.1.0" />
-    <DotNetCliToolReference Include="dotnet-sourcelink" Version="2.1.0" />
-  </ItemGroup>
-
 </Project>

Octokit.Tests.Conventions/Exception/InvalidUrlPropertyTypeException.cs

@@ -13,7 +13,7 @@ public InvalidUrlPropertyTypeException(Type modelType, IEnumerable<PropertyInfo>
 
         static string CreateMessage(Type modelType, IEnumerable<PropertyInfo> propertiesWithInvalidType)
         {
-            return string.Format("Model type '{0}' contains the following properties that are named or suffixed with 'Url' but are not of type String: {!}{2}",
+            return string.Format("Model type '{0}' contains the following properties that are named or suffixed with 'Url' but are not of type String: {1}{2}",
                 modelType.FullName,
                 Environment.NewLine,
                 string.Join(Environment.NewLine, propertiesWithInvalidType.Select(x => x.Name)));

Octokit.Tests.Conventions/Octokit.Tests.Conventions.csproj

@@ -9,8 +9,6 @@
     <AssemblyName>Octokit.Tests.Conventions</AssemblyName>
     <PackageId>Octokit.Tests.Conventions</PackageId>
     <GenerateRuntimeConfigurationFiles>true</GenerateRuntimeConfigurationFiles>
-    <NetStandardImplicitPackageVersion>1.6.0</NetStandardImplicitPackageVersion>
-    <RuntimeFrameworkVersion>1.0.4</RuntimeFrameworkVersion>
     <GenerateAssemblyTitleAttribute>false</GenerateAssemblyTitleAttribute>
     <GenerateAssemblyDescriptionAttribute>false</GenerateAssemblyDescriptionAttribute>
     <GenerateAssemblyConfigurationAttribute>false</GenerateAssemblyConfigurationAttribute>

Octokit.Tests.Integration/Clients/GitHubAppsClientTests.cs

@@ -0,0 +1,130 @@
+using Octokit.Tests.Integration.Helpers;
+using System;
+using System.Linq;
+using System.Threading.Tasks;
+using Xunit;
+
+namespace Octokit.Tests.Integration.Clients
+{
+    public class GitHubAppsClientTests
+    {
+        public class TheGetMethod
+        {
+            IGitHubClient _github;
+
+            public TheGetMethod()
+            {
+                // Regular authentication
+                _github = Helper.GetAuthenticatedClient();
+            }
+
+            [GitHubAppsTest]
+            public async Task GetsApp()
+            {
+                var result = await _github.GitHubApps.Get(Helper.GitHubAppSlug);
+
+                Assert.Equal(Helper.GitHubAppId, result.Id);
+                Assert.False(string.IsNullOrEmpty(result.Name));
+                Assert.NotNull(result.Owner);
+            }
+        }
+
+        public class TheGetCurrentMethod
+        {
+            IGitHubClient _github;
+
+            public TheGetCurrentMethod()
+            {
+                // Authenticate as a GitHubApp
+                _github = Helper.GetAuthenticatedGitHubAppsClient();
+            }
+
+            [GitHubAppsTest]
+            public async Task GetsCurrentApp()
+            {
+                var result = await _github.GitHubApps.GetCurrent();
+
+                Assert.Equal(Helper.GitHubAppId, result.Id);
+                Assert.False(string.IsNullOrEmpty(result.Name));
+                Assert.NotNull(result.Owner);
+            }
+        }
+
+        public class TheGetAllInstallationsForCurrentMethod
+        {
+            IGitHubClient _github;
+
+            public TheGetAllInstallationsForCurrentMethod()
+            {
+                // Authenticate as a GitHubApp
+                _github = Helper.GetAuthenticatedGitHubAppsClient();
+            }
+
+            [GitHubAppsTest]
+            public async Task GetsAllInstallations()
+            {
+                var result = await _github.GitHubApps.GetAllInstallationsForCurrent();
+
+                Assert.True(result.Any(x => x.Id == Helper.GitHubAppInstallationId));
+                foreach (var installation in result)
+                {
+                    Assert.Equal(Helper.GitHubAppId, installation.AppId);
+                    Assert.NotNull(installation.Account);
+                    Assert.NotNull(installation.Permissions);
+                    Assert.Equal(InstallationPermissionLevel.Read, installation.Permissions.Metadata);
+                    Assert.False(string.IsNullOrEmpty(installation.HtmlUrl));
+                    Assert.NotEqual(0, installation.TargetId);
+                }
+            }
+        }
+
+        public class TheGetInstallationMethod
+        {
+            IGitHubClient _github;
+
+            public TheGetInstallationMethod()
+            {
+                // Authenticate as a GitHubApp
+                _github = Helper.GetAuthenticatedGitHubAppsClient();
+            }
+
+            [GitHubAppsTest]
+            public async Task GetsInstallation()
+            {
+                var installationId = Helper.GitHubAppInstallationId;
+
+                var result = await _github.GitHubApps.GetInstallation(installationId);
+
+                Assert.True(result.AppId == Helper.GitHubAppId);
+                Assert.Equal(Helper.GitHubAppId, result.AppId);
+                Assert.NotNull(result.Account);
+                Assert.NotNull(result.Permissions);
+                Assert.Equal(InstallationPermissionLevel.Read, result.Permissions.Metadata);
+                Assert.False(string.IsNullOrEmpty(result.HtmlUrl));
+                Assert.NotEqual(0, result.TargetId);
+            }
+        }
+
+        public class TheCreateInstallationTokenMethod
+        {
+            IGitHubClient _github;
+
+            public TheCreateInstallationTokenMethod()
+            {
+                // Authenticate as a GitHubApp
+                _github = Helper.GetAuthenticatedGitHubAppsClient();
+            }
+
+            [GitHubAppsTest]
+            public async Task GetsInstallation()
+            {
+                var installationId = Helper.GitHubAppInstallationId;
+
+                var result = await _github.GitHubApps.CreateInstallationToken(installationId);
+
+                Assert.NotNull(result.Token);
+                Assert.True(DateTimeOffset.Now < result.ExpiresAt);
+            }
+        }
+    }
+}