Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix errors in ObservableEventsClient caused by incorrect return types #1490

Merged
merged 4 commits into from
Oct 19, 2016
Merged

Fix errors in ObservableEventsClient caused by incorrect return types #1490

merged 4 commits into from
Oct 19, 2016

Conversation

StanleyGoldman
Copy link
Contributor

#1251 threw me for a loop for a bit.

It turns out this API deals in IssueEvent not Activity.

@StanleyGoldman
Copy link
Contributor Author

Hmm, I might need some help understanding why the integration tests fail.
I supplied a username, organization, and token in Octokit.Tests.Integration.Helper and the rest seemed to work for me.

@shiftkey
Copy link
Member

shiftkey commented Oct 9, 2016

@StanleyGoldman these failures appear related to the unit tests - check the mocks locally as they may need to be updated.

Also, have you checked the Slow Tests section in the CONTRIBUTING docs? That should help you setup your environment for testing.

@StanleyGoldman
Copy link
Contributor Author

Hey @shiftkey I didn't see the Slow Tests documentation, I will definitely give it a try tonight.
It's just odd because I did what I feel was an equivalent locally, which passed during tests.
I'll let you know how it goes.

@StanleyGoldman
Copy link
Contributor Author

@shiftkey Good to go.

@shiftkey
Copy link
Member

@StanleyGoldman thanks!

@shiftkey shiftkey merged commit e2af971 into octokit:master Oct 19, 2016
@StanleyGoldman StanleyGoldman deleted the fixes/issue-events branch October 20, 2016 00:56
@ryangribble ryangribble changed the title Correcting return type in ObservableEventsClient Fix errors in ObservableEventsClient caused by incorrect return types Jan 15, 2017
@nickfloyd nickfloyd added Type: Bug Something isn't working as documented and removed category: bug labels Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working as documented
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants