Change PublicRepositoryRequest ctor to take long for "since" parameter #1485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… long, and obsolete the old ctor that uses an int Update tests to pass long datatype
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We changed all repositoryId parameters from
inttolongin #1445 and missed this one.The
ctoronPublicRepositoryRequesttakes a "since" parameter of typeint.If anyone is passing in a
repository.Id(now along) into thisctorit will result in a compilation error.This PR adds a new
ctorto PublicRepositoryRequest taking "since" parameter as along, and obsoletes the oldctor. I thought about simpl keeping theintctoraround indefinitely but I think in general we want to encourage/inform users thatrepositoryId(and any related uses, such as the "Since" parameter) are nowlongacross the board, so I decided to start the process of removing the oldintparameter via obsoletion.Also updated any tests that use the
ctorto use the new one instead...