Add repository traffic preview

[martinscholz83]

fix #1447

Implement client for the new repository traffic api.

[martinscholz83]

Maybe someone has a better naming for TrafficeDayOrWeek 😸

[martinscholz83]

@ryangribble, what about integration tests for this feature. The only thing we can test is that the result is not null 😑. And of course the result count is 0.. Should i do that?

[ryangribble]

I guess integration tests still prove everything is wired up correctly, even if there aren't any meaningful stats...

I take it we can't point the calls at an existing repository due to permissions?

[martinscholz83]

Yeap, you need to have push access.

[martinscholz83]

[martinscholz83]

Hi @ryangribble, is this ready for 🚢?

[ryangribble]

Hi @maddin2016

Do you think you could add some integration tests then flag them as Skipped due to requiring admin permissions. This way I can at least run these locally (after changing the repostory to something I do have admin permissions on and unskipping the tests) to ensure the functionality is working as intended?

[ryangribble]

Hey @maddin2016

Thanks for adding the tests - lucky we did because there was actually an issue with timestamps! 😀

I pulled everything down and ran through it, and these are the things I changed:

• RepositoryId was recently changed from int to long in Change repository id from int to long #1445 so the repositoryId parameters in this new API need to be long now too
• The timestamp field in the Api responses is in unix utc time, and doesn't deserialize into a DateTimeOffset directly, causing exceptions on the View and Clone methods when the repository actually had some data to return for these calls
• I wasnt a fan of naming the item level classes View and Clone since they are a bit too generic IMO
• I also thought naming some methods GetAllxxx() when they don't support pagination we can use the new [ExcludeFromPaginationConventionTests] so we can call them GetReferrers() and GetPaths() which is more inline with what they do (it's not all referrers, just referrers from last 14 days etc)
• Integration tests were added for owner/name methods but not for repositoryId methods

As I was working through things I ended up making local fixes anyhow, so I've pushed a commit that addresses these already if you want to cherry pick it in: TattsGroup@b145bb3

If you are interested in how we handle the timestamp thing, basically in other areas of the codebase we have a pattern already, where we add a long TimestampAsUtcEpochSeconds field to take the deserialized value (using the Parameter override to map it to timestamp) and then add a DateTimeOffset Timestamp getter property that uses a helper function to convert the unix time into DateTimeOffset. it looks something like this (and you'll see these fixes in my commit):

        [Parameter(Key = "ignoreThisField")]
        public DateTimeOffset Timestamp
        {
            get { return TimestampAsUtcEpochSeconds.FromUnixTime(); }
        }

        [Parameter(Key = "timestamp")]
        public long TimestampAsUtcEpochSeconds { get; protected set; }

Let me know what you think of my changes

[martinscholz83]

Hi @ryangribble, thanks for your review. I have read on the format of timestamp. Is there any explanation why it's this format? And yes, View is realy a bit to common 😁. The renaiming of GetAllxxx() makes sense. I already have this in mind but i don't know wheter it woul be correct. So many thanks for your fixes 👍

[martinscholz83]

And the renaming of the repsitory id's i have forgotten, because i already did this in another PR 😅

[ryangribble]

Thanks for another great contribution @maddin2016 😀

[martinscholz83]

Many thanks @ryangribble