-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Gist API #216
Comments
I've start implement the gist API. Shall I also implement the comments API as a subclient of Gist or I have to open a new issue? |
@xabikos we're following the layout of the documentation site to be consistent with how users would explore it In this case
|
@shiftkey thanks for the reply. I'll continue implementing the gists API and maybe afterwards implement the comments API as well. Regarding the gists shall I make a pull request for every one of above check boxes or only when all of them are finished? |
Keep in mind that #239 is underway for creating gists |
Thanks @shiftkey for remind it to me 👍 |
Doing it incrementally makes for easier code reviews on my end, but up to you. The checkboxes are just there to ensure that duplication of work isn't happening |
I made a pull request for some of the methods related to gists. I created a topic branch (implement-gist-api) when I for the repository and worked on this branch. I made the pull request and didn't merge my topic branch to the master first. Is this correct? This is my first attempt for a pull request. |
Except the above comment I have a question regarding the check if a gist is stared method. We have to make a get request to /gists/:id/star url and based on the response code (204, 404) return true or false. I couldn't find an easy solution to access the response code through API connection. Any suggestions on how to implement this? Shall I add an extra method to API connection to access the request response? |
- [ ] Finish Gists API Implementation - [ ] [Add method to get gist commits](https://developer.github.com/v3/gists/#list-gist-commits) - [ ] [Add method to get gist forks](https://developer.github.com/v3/gists/#list-gist-forks) Fixes octokit#328, Fixes octokit#216 Added implementation for the remaining pieces of the Gists API. The others mentioned in octokit#328 and octokit#216 were completed through other PRs.
There's a few here, so let's break it down and track the progress:
http://developer.github.com/v3/gists/
The text was updated successfully, but these errors were encountered: