Use IReadOnlyList instead of IReadOnlyCollection or IEnumerable

Octokit.Tests/Helpers/AssertEx.cs

@@ -51,7 +51,7 @@ public static void IsReadOnlyCollection<T>(object instance) where T : class
         {
             var collection = instance as ICollection<T>;
             // The collection == null case is for .NET 4.0
-            Assert.True(instance is IReadOnlyCollection<T> && (collection == null || collection.IsReadOnly));
+            Assert.True(instance is IReadOnlyList<T> && (collection == null || collection.IsReadOnly));
         }
     }
 }

Octokit/Models/Request/BaseSearchRequest.cs

@@ -59,7 +59,7 @@ private string SortOrder
         /// <summary>
         /// All qualifiers that are used for this search
         /// </summary>
-        public abstract IReadOnlyCollection<string> MergedQualifiers();
+        public abstract IReadOnlyList<string> MergedQualifiers();
 
         /// <summary>
         /// Add qualifiers onto the search term

Octokit/Models/Request/SearchCodeRequest.cs

@@ -111,7 +111,7 @@ public IEnumerable<CodeInQualifier> In
         public string Repo { get; set; }
 
         [SuppressMessage("Microsoft.Globalization", "CA1304:SpecifyCultureInfo", MessageId = "System.String.ToLower")]
-        public override IReadOnlyCollection<string> MergedQualifiers()
+        public override IReadOnlyList<string> MergedQualifiers()
         {
             var parameters = new List<string>();
 

Octokit/Models/Request/SearchIssuesRequest.cs

@@ -176,7 +176,7 @@ public IEnumerable<string> Labels
         /// </remarks>
         public string Repo { get; set; }
 
-        public override IReadOnlyCollection<string> MergedQualifiers()
+        public override IReadOnlyList<string> MergedQualifiers()
         {
             var parameters = new List<string>();
 

Octokit/Models/Request/SearchRepositoriesRequest.cs

@@ -101,7 +101,7 @@ public IEnumerable<InQualifier> In
         /// </summary>
         public DateRange Updated { get; set; }
 
-        public override IReadOnlyCollection<string> MergedQualifiers()
+        public override IReadOnlyList<string> MergedQualifiers()
         {
             var parameters = new List<string>();
 

Octokit/Models/Request/SearchUsersRequest.cs

@@ -84,7 +84,7 @@ public IEnumerable<UserInQualifier> In
             }
         }
 
-        public override IReadOnlyCollection<string> MergedQualifiers()
+        public override IReadOnlyList<string> MergedQualifiers()
         {
             var parameters = new List<string>();
 

Octokit/Models/Response/CompareResult.cs

@@ -19,7 +19,7 @@ public class CompareResult
         public int AheadBy { get; protected set; }
         public int BehindBy { get; protected set; }
         public int TotalCommits { get; protected set; }
-        public IReadOnlyCollection<GitHubCommit> Commits { get; protected set; }
+        public IReadOnlyList<GitHubCommit> Commits { get; protected set; }
 
         internal string DebuggerDisplay
         {

Octokit/Models/Response/Contributor.cs

@@ -15,7 +15,7 @@ public class Contributor
 
         public int Total { get; protected set; }
 
-        public IEnumerable<WeeklyHash> Weeks { get; protected set; }
+        public IReadOnlyList<WeeklyHash> Weeks { get; protected set; }
 
         internal string DebuggerDisplay
         {

Octokit/Models/Response/Issue.cs

@@ -45,7 +45,7 @@ public class Issue
         /// <summary>
         /// The set of labels applied to the issue
         /// </summary>
-        public IReadOnlyCollection<Label> Labels { get; protected set; }
+        public IReadOnlyList<Label> Labels { get; protected set; }
 
         /// <summary>
         /// The user this issue is assigned to.

Octokit/Models/Response/OauthToken.cs

@@ -21,7 +21,7 @@ public class OauthToken
         /// <summary>
         /// The list of scopes the token includes.
         /// </summary>
-        public IReadOnlyCollection<string> Scope { get; set; }
+        public IReadOnlyList<string> Scope { get; set; }
 
         internal string DebuggerDisplay
         {

Octokit/Models/Response/PunchCard.cs

@@ -20,7 +20,7 @@ public PunchCard(IEnumerable<IList<int>> punchCardData)
         /// <summary>
         /// The raw punch card points
         /// </summary>
-        public IReadOnlyCollection<PunchCardPoint> PunchPoints { get; private set; }
+        public IReadOnlyList<PunchCardPoint> PunchPoints { get; private set; }
 
         /// <summary>
         /// Gets the number of commits made on the specified day of the week

Octokit/Models/Response/TreeResponse.cs

@@ -22,7 +22,7 @@ public class TreeResponse
         /// <summary>
         /// The list of Tree Items for this Tree response.
         /// </summary>
-        public IReadOnlyCollection<TreeItem> Tree { get; protected set; }
+        public IReadOnlyList<TreeItem> Tree { get; protected set; }
 
         internal string DebuggerDisplay
         {

Octokit/SimpleJson.cs

@@ -31,7 +31,7 @@
 // NOTE: uncomment the following line to enable DataContract support.
 //#define SIMPLE_JSON_DATACONTRACT
 
-// NOTE: uncomment the following line to enable IReadOnlyCollection<T> and IReadOnlyList<T> support.
+// NOTE: uncomment the following line to enable IReadOnlyList<T> and IReadOnlyList<T> support.
 //#define SIMPLE_JSON_READONLY_COLLECTIONS
 
 // NOTE: uncomment the following line to disable linq expressions/compiled lambda (better performance) instead of method.invoke().
@@ -1717,7 +1717,7 @@ public static bool IsTypeGenericeCollectionInterface(Type type)
                     || genericDefinition == typeof(ICollection<>)
                     || genericDefinition == typeof(IEnumerable<>)
 #if SIMPLE_JSON_READONLY_COLLECTIONS
-                    || genericDefinition == typeof(IReadOnlyCollection<>)
+                    || genericDefinition == typeof(IReadOnlyList<>)
                     || genericDefinition == typeof(IReadOnlyList<>)
 #endif
                     );