Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set correct user agent #2231

Merged
merged 1 commit into from
Jun 22, 2022
Merged

fix: set correct user agent #2231

merged 1 commit into from
Jun 22, 2022

Conversation

gr2m
Copy link
Contributor

@gr2m gr2m commented Jun 22, 2022

@timrogers @nickfloyd I realized by chance that we set octokit-rest.js in the request header, which really should be octokit.js. That PR fixes it. But in case you want to run any analytics, beware that up till now all request sent using the octokit package look as if they were sent using @octokit/rest package.

@wolfy1339 wolfy1339 added the Type: Bug Something isn't working as documented label Jun 22, 2022
@gr2m gr2m merged commit de8c3a5 into main Jun 22, 2022
@gr2m gr2m deleted the fix-user-agent branch June 22, 2022 18:11
@github-actions
Copy link

🎉 This PR is included in version 1.8.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working as documented
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants