-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: remove previews logic #388
Conversation
BREAKING CHANGE
if (url === "/graphql") { | ||
if (options.mediaType.previews!.length) { | ||
const previewsFromAcceptHeader = | ||
headers.accept.match(/[\w-]+(?=-preview)/g) || ([] as string[]); |
Check failure
Code scanning / CodeQL
Polynomial regular expression used on uncontrolled data
Requires update to |
I'm going to need a hand with some pointers. The {
method: 'POST',
url: 'https://api.github.com//graphql',
headers: {
accept: 'application/vnd.github.package-deletes-preview.json,application/vnd.github.flash-preview-preview.json',
'user-agent': 'myApp v1.2.3+test'
}
} However, in the test that calls |
@gr2m Can you take a look |
We are meddling with the accept header based on the Sorry I can't have a look myself right now, maybe tomorrow after work |
I removed the test that I was having issues with. The coverage is still 100% |
🎉 This PR is included in version 8.0.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Followup to #382 (comment)
Closes #382
Behavior
Before the change?
After the change?
Other information
@octokit/types
, and a release is madeAdditional info
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!
Type: Breaking change
label)If
Yes
, what's the impact:Pull request type
Please add the corresponding label for change this PR introduces:
Type: Bug
Type: Feature
Type: Documentation
Type: Maintenance