Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(test): remove unused tsconfig.test.json #706

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

oscard0m
Copy link
Member

@oscard0m oscard0m commented Oct 3, 2024

After the migration to vitest, it is not necessary anymore to have a custom tsconfig.json


Before the change?

  • We have an unused file in the codebase: tsconfig.test.json

After the change?

  • Same behavior but with unused file removed.

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

After the migration to `vitest`, it is not necessary anymore to have a custom `tsconfig.json`
Copy link
Contributor

github-actions bot commented Oct 3, 2024

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@oscard0m oscard0m added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label Oct 3, 2024
@oscard0m oscard0m requested review from wolfy1339 and removed request for wolfy1339 October 11, 2024 08:48
@wolfy1339 wolfy1339 merged commit 1ec2783 into main Oct 11, 2024
10 checks passed
@wolfy1339 wolfy1339 deleted the remove-unused-tsconfig-for-testing branch October 11, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants