Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lwt.unix: add Lwt_unix.send_msgto that takes a destination address #805

Merged
merged 3 commits into from
Nov 18, 2020
Merged

lwt.unix: add Lwt_unix.send_msgto that takes a destination address #805

merged 3 commits into from
Nov 18, 2020

Conversation

anmonteiro
Copy link
Contributor

This is useful to send IO Vectors over unconnected sockets (e.g. UDP).

@anmonteiro
lwt.unix: add Lwt_unix.send_msgto that takes a destination address
8ee6df4 
This is useful to send IO Vectors over unconnected sockets (e.g. UDP)
raphael-proust
raphael-proust requested changes Sep 12, 2020
View reviewed changes
Copy link
Collaborator

@raphael-proust raphael-proust left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also needs a test. There's already one for send_msg in test/unix/test_lwt_bytes.ml so it'd just be a case of adapting it.

src/unix/unix_c/unix_recv_send_utils.c Outdated Show resolved Hide resolved
@raphael-proust
Copy link
Collaborator

It's good as far as I can tell. Unfortunately this is not very far because of my unfamiliarity with the C bindings. Anyone else can give this a look?

@aantron aantron self-requested a review September 25, 2020 05:41
aantron
aantron approved these changes Sep 25, 2020
View reviewed changes
Copy link
Collaborator

@aantron aantron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code LGTM.

@raphael-proust raphael-proust merged commit 20e8836 into ocsigen:master Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raphael-proust raphael-proust raphael-proust requested changes

@aantron aantron aantron approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anmonteiro @raphael-proust @aantron