Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for selecting the libev backend (more gently) #294

Merged
merged 3 commits into from
Nov 24, 2016

Conversation

aantron
Copy link
Collaborator

@aantron aantron commented Nov 24, 2016

This is a version of #269 that warns current users of Lwt_engine.libev that the signature will change, as per #293.

  • The new version is available as Lwt_engine.Versioned.libev_2. It will be released in the next Lwt release, but will replace the current libev in a major release.

  • The current libev has a warning attached to it in the meantime:

    Warning 3: deprecated: Lwt_engine.libev
    This class will soon have parameters for selecting a libev backend. This will
    be a breaking change. See
      https://github.com/ocsigen/lwt/pull/269
    To preserve the current signature, use Lwt_engine.Versioned.libev_1
    To use the replacement immediately, use Lwt_engine.Versioned.libev_2 ()
    

Resolves #269

cc @yallop I modified the first commit slightly:

  • renamed libev to libev' in the .ml file,
  • defined libev in terms of that, and
  • undid the change to the signature of libev

Hope that is ok.

@yallop
Copy link
Contributor

yallop commented Nov 24, 2016

Yes, that's fine. Thanks for taking care with git history & authorship!

@aantron aantron merged commit 4c1b000 into master Nov 24, 2016
@aantron aantron deleted the libev-backends branch November 24, 2016 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants