Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation improvements #210

Merged
merged 7 commits into from
Jan 18, 2016
Merged

Documentation improvements #210

merged 7 commits into from
Jan 18, 2016

Conversation

Drup
Copy link
Member

@Drup Drup commented Jan 18, 2016

Should fix #209
cc @fxfactorial

For the oasis part of the question, I oppened ocaml/ocamlbuild#45

@aantron
Copy link
Collaborator

aantron commented Jan 18, 2016

You might even want to contrast >> with >>=, since this is what is setting up the expectation in the first place. Note that unlike [>>=], [>>] is not an OCaml value..., or something.

@Drup Drup force-pushed the doc branch 2 times, most recently from b0f6b68 to 195a53e Compare January 18, 2016 17:10
@Drup
Copy link
Member Author

Drup commented Jan 18, 2016

@aantron They are recorded, but it's going to be so mangled it might as well not be the case. I added a slight precision. I also added more pointers to the manual.
Your formulation for >> is better, thanks!

@aantron
Copy link
Collaborator

aantron commented Jan 18, 2016

Strange, why aren't there links to comments on outdated diffs?

@aantron
Copy link
Collaborator

aantron commented Jan 18, 2016

Looks good, apart from the semicolon in the message for 533ef6f :)

Drup added a commit that referenced this pull request Jan 18, 2016
Documentation improvements
@Drup Drup merged commit 4ac2336 into master Jan 18, 2016
@Drup Drup deleted the doc branch January 18, 2016 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation, Documentation, Documentation and backtraces
2 participants