Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lwt_io.shutdown_server should evaluate to a thread #259

Closed
aantron opened this issue Jun 25, 2016 · 0 comments
Closed

Lwt_io.shutdown_server should evaluate to a thread #259

aantron opened this issue Jun 25, 2016 · 0 comments
Labels

Comments

@aantron
Copy link
Collaborator

aantron commented Jun 25, 2016

I.e. instead of

val shutdown_server : server -> unit

have

val shutdown_server : server -> unit Lwt.t

because it is useful to know when the listening socket has been closed, and therefore the address can be reused. The documentation should also be clear that that is what it means to "shut down" a server.

aantron added a commit that referenced this issue Jul 4, 2016
@aantron aantron removed the docs label Jul 4, 2016
aantron added a commit that referenced this issue Nov 25, 2016
aantron added a commit that referenced this issue Apr 8, 2017
aantron added a commit that referenced this issue Apr 9, 2017
aantron added a commit that referenced this issue Apr 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant