Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Eliminate include validation #32

Merged
merged 3 commits into from
Sep 5, 2024
Merged

Eliminate include validation #32

merged 3 commits into from
Sep 5, 2024

Conversation

alanisaac
Copy link
Collaborator

@alanisaac alanisaac commented Sep 4, 2024 •
edited
Loading

Fixes #33

@alanisaac alanisaac marked this pull request as ready for review September 4, 2024 18:13
query-jeremy
query-jeremy previously approved these changes Sep 4, 2024
View reviewed changes
Copy link
Collaborator

@query-jeremy query-jeremy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, Alan!

@query-jeremy
Copy link
Collaborator

Can you bump the version number in pyproject.toml?

@alanisaac
Copy link
Collaborator Author

Can you bump the version number in pyproject.toml?

Oh -- yep! fixed in b2cf4f5

@query-jeremy query-jeremy merged commit 8362af5 into ocsf:main Sep 5, 2024
5 checks passed
@alanisaac alanisaac mentioned this pull request Sep 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@query-jeremy query-jeremy query-jeremy approved these changes

@floydtree floydtree floydtree approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Eliminate includes validation
3 participants
@alanisaac @query-jeremy @floydtree