-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create osint
Profile
#992
Create osint
Profile
#992
Conversation
Aside from this being really well worked out, it is also quite a substantial amount of STIX / TI specific information, with some naming questions here (some attributes are I also feel there is enough to merit a "platform" of sorts where it can be package up within a core extension. I know that our core extensions today are "OS platform" extensions and STIX isn't exactly the same thing, but we can have OCSF extensions just like we can have vendor extensions. External standards can be modeled this way, keeping attributes in their own dictionary. The notation would already scope by extension name (e.g. stix/xx). Same can be done for d3fend, which we are considering for a Remediation category. Otherwise, the core dictionary will get very large and there will be a lot of external standards specific naming mixed in. |
@pagbabian-splunk I agree on the overall approach. I feel we should go ahead and remove the |
threat_intelligence
Profile, add STIX 2.1 SDOs to OCSFopen_source_intelligence
Profile
Signed-off-by: Jonathan Rau <[email protected]>
d687239
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting in all the feedback! I think we are almost there. I have added a few line specific comments, but in general, if we want this profile to be usable by event classes in the framework we need to add it to those classes. Currently, if you run the server locally, you'll notice the profile won't even be visible in the profiles page, since it's not registered with any class.
Having said that, I would expect this profile to be available for all the classes. If that's your intention as well, then you'll need to add it to the base_event
definition - similar to how cloud, datetime are added. Happy to discuss further.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, looks perfect now. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work on this!
Related Issue:
#988
Description of changes:
osint
object.osint
Profile based onosint
object.signatures
object, an array ofsignature
objects.subdomains
object, an array ofsubdomain
used to enumerate DGA-generated domains.whois
object.contact
and array-typedcontacts
object for use withwhois
object.is_self_signed
Boolean attribute tocertificate
object.Several dozen attributes were added to
dictionary
to supportwhois
andcontact
.