Correct type for priority field #959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jason Bertman <[email protected]>
Signed-off-by: Jason Bertman <[email protected]>
jbertman
requested review from
floydtree,
pagbabian-splunk,
Aniak5,
mikeradka and
zschmerber
as code owners
mikeradka
previously approved these changes
Feb 7, 2024
|
This is definitely a bug, thanks for fixing it! |
floydtree
added
bug
floydtree
requested changes
Feb 7, 2024
Signed-off-by: Jason Bertman <[email protected]>
floydtree
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Other normalized string fields that map to an enum are strings, not integers. The sample data API generates a string for the
priorityfield, which fails the JSON schema validation. This corrects the type to reflect the paradigm in the rest of the schema.