-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Data Security Finding event class & Data Security object #953
Conversation
Signed-off-by: Jonathan Rau <[email protected]>
Signed-off-by: Jonathan Rau <[email protected]>
Signed-off-by: Jonathan Rau <[email protected]>
add findings/data_security_finding
Signed-off-by: Jonathan Rau <[email protected]>
Based on feedback from @zschmerber will make the following changes
|
Signed-off-by: Jonathan Rau <[email protected]>
Signed-off-by: Jonathan Rau <[email protected]>
Signed-off-by: Jonathan Rau <[email protected]>
I am wondering if the I'm not sure you need the evidence object but that is how Detections finding has it so I thought I would pose the question. |
In my initial design that is how I had it, but my thoughts to not use it are twofold:
Of course, there can be a multitude of data sources implicated by a specific finding too. I guess in that case, when it comes to ETL/ELT systems, is the argument that it is easier to add multiple types of In the case of multiple sources implicated, no issue adding I guess this is another case of balancing the data engineering effort (mapping) against the data analysis effort (search, detections, etc.) |
This looks really good overall - a couple of things though: enums should be |
Signed-off-by: Jonathan Rau <[email protected]>
Signed-off-by: Jonathan Rau <[email protected]>
Data Security Finding patch 2
Thanks @pagbabian-splunk , just made the required changes. Forgot that the objects and event would inherit from |
@jonrau-at-queryai One quick note, can you add relevant entries in the |
Signed-off-by: Jonathan Rau <[email protected]>
Done! |
Signed-off-by: Jonathan Rau <[email protected]>
Signed-off-by: Jonathan Rau <[email protected]>
Signed-off-by: Jonathan Rau <[email protected]>
Update `pattern_match` in dictionary and data security object
@floydtree @mikeradka put in both changes you folks wanted |
Signed-off-by: Jonathan Rau <[email protected]>
Signed-off-by: Jonathan Rau <[email protected]>
Signed-off-by: Jonathan Rau <[email protected]>
Signed-off-by: Jonathan Rau <[email protected]>
`analytic` update for `data_security` object
…lytic` Signed-off-by: Jonathan Rau <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! This is great.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Related Issue:
NaN
Description of changes:
BLUF: Add a new Finding category event class: Data Security Finding, add a new object: Data Security to support normalization and standardization of Data Loss Prevention (DLP), Data Security Posture Management (DSPM), and similar findings
Data Security Finding was modeled on Detection Finding and Datastore Activity events, appropriate objects from each were pulled into the finding along with other top-level objects to support a wide amount of normalization. Several objects were added at the top level such as
databucket
,database
,table
,file
,actor
and others to account for the different places that a finding can trigger from and keep track of who owns the datastores or who triggered the finding.The Data Security object will contain information about the relevant policy(s), the lifecycle of the data (rest/use/transit), the type of tool, the type of detection technique, as well as string values to include the name of the specific detections (or the regex) and the source of the pattern match.