Issue 756: Deprecate http_status
#767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ania Kacewicz <[email protected]>
Signed-off-by: Ania Kacewicz <[email protected]>
Aniak5
requested review from
rroupski,
jp-harvey,
pagbabian-splunk and
mikeradka
Aniak5
changed the title
http_statushttp_status
rroupski
requested changes
Sep 7, 2023
There was a problem hiding this comment.
Similar to the http_response.status description, you should update the http_response.code description as well. For example:
The Hypertext Transfer Protocol (HTTP) status code returned from the web server to the client. For example, 200.
Signed-off-by: Ania Kacewicz <[email protected]>
Signed-off-by: Ania Kacewicz <[email protected]>
pagbabian-splunk
approved these changes
Sep 7, 2023
mikeradka
approved these changes
Sep 7, 2023
rroupski
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #756
Description of changes:
latencyand http response status