-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 538: Add CWE Object #558
Conversation
Already defined externally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree adding cwe object to vulnerability; However, cwe info shouldn't be removed from CVE object. Malware object contains list of CVEs and cwe information has to be associated with CVE object. In CVE object cwe_uid and cwe_url attributes can be replaced with new CWE object.
That's valid. Good call. CWE fields restored in CVE object. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You would need to add a cwe
object in the dictionary for this to work correctly. For reference check definition of cve object in the dictionary.
Currently, if you run a local server instance, you should see the following error message -
Warning: 16:46:23.154 [warning] 'Vulnerability Details' uses undefined attribute: cwe: %{_source: :vulnerability, requirement: "recommended"}
Also, I would highly recommend, running a local instance of the OCSF server and checking if the desired schema changes are accurately reflected in the browser.
@Apocrathia I can add |
Any progress with this item? |
Hello, commenting on this closed issue trying to understand why this was closed. I'm working on ingesting some security tool output into OCSF and CWE is definitely useful without a CVE, but this is required for vulnerability detail object. The only other option I can see is using finding detail, but CWE details will be hidden in the |
#538