Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 538: Add CWE Object #558

Closed
wants to merge 9 commits into from
Closed

Conversation

Apocrathia
Copy link

#538

  • Added CWE object type to schema
  • Configured Vulnerability object to accept CWE or CVE object
  • Removed CWE field from CVE object (this can still be determined from an external lookup of the CVE object if needed.)

Copy link
Contributor

@irakledibm irakledibm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree adding cwe object to vulnerability; However, cwe info shouldn't be removed from CVE object. Malware object contains list of CVEs and cwe information has to be associated with CVE object. In CVE object cwe_uid and cwe_url attributes can be replaced with new CWE object.

@Apocrathia
Copy link
Author

Apocrathia commented Apr 5, 2023

cwe info shouldn't be removed from CVE object. Malware object contains list of CVEs and cwe information has to be associated with CVE object.

That's valid. Good call. CWE fields restored in CVE object.
a0d8d71

Copy link
Contributor

@floydtree floydtree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You would need to add a cwe object in the dictionary for this to work correctly. For reference check definition of cve object in the dictionary.
Currently, if you run a local server instance, you should see the following error message -
Warning: 16:46:23.154 [warning] 'Vulnerability Details' uses undefined attribute: cwe: %{_source: :vulnerability, requirement: "recommended"}

Also, I would highly recommend, running a local instance of the OCSF server and checking if the desired schema changes are accurately reflected in the browser.

@pagbabian-splunk
Copy link
Contributor

@Apocrathia I can add cwe to the dictionary if it helps to get this PR approved and merged.

@irakledibm
Copy link
Contributor

Any progress with this item?

@Apocrathia Apocrathia closed this May 17, 2023
@Apocrathia Apocrathia deleted the issue-538 branch May 17, 2023 14:32
@rafaelpereyra
Copy link

Hello, commenting on this closed issue trying to understand why this was closed.

I'm working on ingesting some security tool output into OCSF and CWE is definitely useful without a CVE, but this is required for vulnerability detail object.

The only other option I can see is using finding detail, but CWE details will be hidden in the supporting_data field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants