-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds ext
attribute to File
object
#1046
Conversation
bb92c3c
to
e4c6ed6
Compare
ext
attribute to File
object
e4c6ed6
to
e92f004
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a consideration about the dictionary's caption/description.
e92f004
to
c765770
Compare
a48fadf
c765770
to
a48fadf
Compare
a48fadf
to
772beb2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great now.
Related Issue:
Closes #1043
Description of changes:
This adds a new
ext
attribute to theFile
object