-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address gaps in Process Activity and Memory Activity wrt process injection. #1042
Conversation
Setting the version to v1.2.0-rc.1 Signed-off-by: Rajas <[email protected]>
Signed-off-by: Michael Radka <[email protected]>
Signed-off-by: Michael Radka <[email protected]>
Signed-off-by: Michael Radka <[email protected]>
Signed-off-by: Michael Radka <[email protected]>
…ction. Signed-off-by: Dave McCormack <[email protected]>
Signed-off-by: Dave McCormack <[email protected]>
It says that I should put labels on this but the ability to do that seems to be disabled for me. The labels I would use if I could would be |
This is a great catch, @davemcatcisco. One minor thing, could you change the branch to be merged to as EDIT: This is TBD based on how things go with the 1.2.0 RC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For process_activity
we are adding an additional injection type, is this the more specific way people think of process injection via memory activity? In other words, is the same situation representable as both process activity or memory activity?
Thanks, Paul. I'm not sure I fully understand your question but I'll just say this in case it helps. Process injection broadly speaking requires two distinct things to happen:
It is important, I think, that these continue to be treated as two distinct activities because each can be used in isolation for other purposes, some benign and some not. |
The base branch was changed.
Closing as this PR has now been superseded by #1060. |
Related Issue:
#1041: Process Activity and Memory Activity cannot adequately describe common injection-related behaviours
Description of changes:
injection_type_id
enum in dictionary.json to cover queueing of an asynchronous procedure call (APC).activity_id
enum in events/system/memory.json to cover mapping of shared memory object.