Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix punctuation for transmit_time #1001

Merged
merged 3 commits into from
Apr 2, 2024
Merged

Fix punctuation for transmit_time #1001

merged 3 commits into from
Apr 2, 2024

Conversation

mikeradka
Copy link
Contributor

Related Issue:

N/A

Description of changes:

Simple punctuation fix to for the transmit_time description.

@mikeradka mikeradka added grammar_consistency Issues related to the attribute grammar consistency work-stream v2.0 and later Changes marked for v2.0 of OCSF, due to their breaking nature labels Apr 1, 2024
@mikeradka mikeradka self-assigned this Apr 1, 2024
@mikeradka
Update CHANGELOG
b8a00f6 
Signed-off-by: Michael Radka <[email protected]>
alanisaac
alanisaac approved these changes Apr 1, 2024
View reviewed changes
Copy link
Contributor

@alanisaac alanisaac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the rule "descriptions should be full sentences with punctuation" something we want to try to enforce in the future in some way with linting or validation?

@mikeradka
Copy link
Contributor Author

Is the rule "descriptions should be full sentences with punctuation" something we want to try to enforce in the future in some way with linting or validation?

I think it would be smart to do, so long as it doesn't introduce problems for us down the road which I am having trouble forseeing. After all, we want our descriptions to be as polished and grammatically correct+consistent as possible.

Aniak5
Aniak5 approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@Aniak5 Aniak5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@Aniak5 Aniak5 merged commit 4406dfe into ocsf:main Apr 2, 2024
2 checks passed
@mikeradka mikeradka deleted the fix_puntuation branch April 2, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmouritzen-splunk rmouritzen-splunk rmouritzen-splunk approved these changes

@alanisaac alanisaac alanisaac approved these changes

@Aniak5 Aniak5 Aniak5 approved these changes

@floydtree floydtree Awaiting requested review from floydtree floydtree is a code owner

@pagbabian-splunk pagbabian-splunk Awaiting requested review from pagbabian-splunk pagbabian-splunk is a code owner

@zschmerber zschmerber Awaiting requested review from zschmerber zschmerber is a code owner

@adplotzk adplotzk Awaiting requested review from adplotzk

@dkolbly dkolbly Awaiting requested review from dkolbly

Assignees

@mikeradka mikeradka

Labels
grammar_consistency Issues related to the attribute grammar consistency work-stream v2.0 and later Changes marked for v2.0 of OCSF, due to their breaking nature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mikeradka @Aniak5 @alanisaac @rmouritzen-splunk