Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional types for device (endpoint) object #1120

Closed
zl551q opened this issue Jun 25, 2024 · 1 comment
Closed

Additional types for device (endpoint) object #1120

zl551q opened this issue Jun 25, 2024 · 1 comment

Comments

@zl551q
Copy link
Contributor

zl551q commented Jun 25, 2024

As a mapper, I need to be able to appropriately taxonomize events that come in from Routers, IDS, and IPS devices. The existing type_id enum within the Device (Endpoint) object do not allow for these types of devices.

AC:

  1. Router, IDS, and IPS have entries in the Endpoint type_id enum
@zl551q zl551q mentioned this issue Jun 25, 2024
Merged
@zl551q
Copy link
Contributor Author

zl551q commented Jul 2, 2024

PR #1121

floydtree added a commit that referenced this issue Jul 9, 2024
@zl551q @floydtree
Add router, ids, and ips entries to type_id enum in the Endpoint obje…
f83ba83 
…ct (#1121)

#### Related Issue: 
[1120](#1120)

#### Description of changes:
Adds three enum type_id values to the Endpoint object:
- router
- ids
- ips

Miscellaneous: Updates grammar on the IOT entry.

I confirm that I have tested the changes, and the server run was error
free. New entries shown with server run:

![image](https://github.com/ocsf/ocsf-schema/assets/173811405/01ce99f7-2451-46ef-a8ac-cea3caf1192e)

Co-authored-by: Rajas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@floydtree @zl551q