-
Notifications
You must be signed in to change notification settings - Fork 136
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Adding vendor provided severity info to finding_info (#1257)
#### Scenario that this change aims to support Consider an finding vendor/producer emits a Finding event. The event is consumed by a different system which allow mutability of events, effectively, allowing end-users to update values in the finding. Case in point, consider `severity`. In such a case, how do you ensure the original vendor/producer's severity value is not lost? -> By utilizing this object to store the original values. The end-user can the simply update the top level values in the finding, as the system would maintain the original values in this object. #### Description of changes: 1. Adding a new object `vendor_attributes` as an optional attribute to all Findings category classes (except the deprecated Security Finding class). 2. Relevant dictionary entries. 3. Fixing missing PR number from a previous changelog entry. #1249 Object Details - ![Screenshot 2024-11-20 at 10 58 52](https://github.com/user-attachments/assets/b28988b3-7d19-4a22-97de-38f8b14f20ea) --------- Signed-off-by: Rajas Panat <[email protected]>
- Loading branch information
Showing
5 changed files
with
34 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
{ | ||
"caption": "Vendor Attributes", | ||
"description": "The Vendor Attributes object can be used to represent values of attributes populated by the Vendor/Finding Provider. It can help distinguish between the vendor-prodvided values and consumer-updated values, of key attributes like <code>severity_id</code>.<br>The original finding producer should not populate this object. It should be populated by consuming systems that support data mutability.", | ||
"extends": "object", | ||
"name": "vendor_attributes", | ||
"attributes": { | ||
"severity": { | ||
"description": "The finding severity, as reported by the Vendor (Finding Provider). The value should be normalized to the caption of the <code>severity_id</code> value. In the case of 'Other', it is defined by the source.", | ||
"requirement": "optional" | ||
}, | ||
"severity_id": { | ||
"description": "The finding severity ID, as reported by the Vendor (Finding Provider).", | ||
"requirement": "optional" | ||
} | ||
} | ||
} | ||
|