-
-
Notifications
You must be signed in to change notification settings - Fork 10.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor improvements to child window resizing behavior #7440
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocornut
pushed a commit
that referenced
this pull request
Mar 27, 2024
ocornut
added a commit
that referenced
this pull request
Mar 27, 2024
…than inner clipping rectangle. (#7440)
Hello, Using WorkRect instead of InnerClipRect is however incorrect. WorkRect encompass the scrolling area. ImRect border_limit_rect = window->ParentWindow->InnerRect;
border_limit_rect.Expand(ImVec2(-ImMax(window->WindowPadding.x, window->WindowBorderSize), -ImMax(window->WindowPadding.y, window->WindowBorderSize)));
if ((parent_flags & (ImGuiWindowFlags_HorizontalScrollbar | ImGuiWindowFlags_AlwaysHorizontalScrollbar)) == 0 || (parent_flags & ImGuiWindowFlags_NoScrollbar))
border_target.x = ImClamp(border_target.x, border_limit_rect.Min.x, border_limit_rect.Max.x);
if (parent_flags & ImGuiWindowFlags_NoScrollbar)
border_target.y = ImClamp(border_target.y, border_limit_rect.Min.y, border_limit_rect.Max.y); I pushed that as 742e534 Eventually we should apply #3312 and might add a helper rectangle corresponding to that. Thank you! |
pull bot
pushed a commit
to TeamREPENTOGON/imgui
that referenced
this pull request
Mar 27, 2024
… clamp child resizes. (ocornut#7440, ocornut#1710)
pull bot
pushed a commit
to TeamREPENTOGON/imgui
that referenced
this pull request
Mar 27, 2024
…than inner clipping rectangle. (ocornut#7440)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Child window resizing is currently clamped to the parent window only if the child window itself has no scrollbar on that axis. It seems unintuitive to look at the child window's scrollbars rather than at the parent window's.
In a situation where the parent window is non-resizable, has scrollbars+mousewheel disabled and persistent storage enabled, that makes it very easy for end users to accidentally brick their UI until the .ini is manually cleared.
This PR also changes the clamp rect to take into account window padding. Currently it has half the window padding at the right side and no padding at the bottom. It's asymmetrical and makes it hard to neatly align a resizable child with other full-width items (eg. -FLT_MIN).
Lastly, this PR extends child window resize grips to cover the entire border length since childs don't have diagonal resize grips at the corners.