Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fonts: Fix clang compiling warning&error with freetype&lunasvg #6873

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

DKingAlpha
Copy link
Contributor

clang-16 is complaining about gcc-specific options and wrong template type.

[build] /some/path/imgui/misc/freetype/imgui_freetype.cpp:845:5: error: no matching function for call to 'IM_DELETE'
[build]     IM_DELETE(*(LunasvgPortState*)_state);
[build]     ^~~~~~~~~
[build] /some/path/imgui/imgui.h:1798:27: note: candidate template ignored: could not match 'T *' against 'LunasvgPortState'
[build] template<typename T> void IM_DELETE(T* p)   { if (p) { p->~T(); ImGui::MemFree(p); } }
[build]                           ^
[build] 1 error generated.
[build] ninja: build stopped: subcommand failed.

Checkout PR commit for details.

@ocornut ocornut merged commit 701a047 into ocornut:master Sep 28, 2023
@ocornut
Copy link
Owner

ocornut commented Sep 28, 2023

Thank you, it was an error in d6360c1
This is not a well tested path unfortunately, I suppose we should add it to CI someday.

@DKingAlpha DKingAlpha deleted the fix-freetype-lunasvg branch September 28, 2023 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants