Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds osx example #575

Merged
merged 1 commit into from
Apr 5, 2016
Merged

Adds osx example #575

merged 1 commit into from
Apr 5, 2016

Conversation

dumganhar
Copy link
Contributor

ios & osx example share the same project but different targets.

@ocornut
Copy link
Owner

ocornut commented Apr 5, 2016

Hello,

Could glfw binaries be obtained via a package manager available on OSX?
The only reason we provide binaries for windows is that it is a nightmare to get any library working under Windows, but OSX has been better.

@dumganhar
Copy link
Contributor Author

@ocornut, No problem, I'll do that. :)

@ocornut
Copy link
Owner

ocornut commented Apr 5, 2016

Thanks a lot!
Ideally removing the GLFW files from the existing commits from save space on the repository. There's probably some git magic technique for that (or don't hesitate to create a new PR if that's easier).

@dumganhar
Copy link
Contributor Author

Yep, I will rebase the Pull Request.

Squashed commits:
[34cc3b7] Adds osx example. (+6 squashed commits)
Squashed commits:
[20330f2] Uses glfw by brew install.
[0427861] Renames imguiex folder name to imguiex-ios
[f9e27e5] Renames ios_example to apple_example.
[44f8fe3] Updates the glfw header/library path.
[919f279] Renames target from imguiex to imguiex-ios since there is already a imguiex-osx target now.
[24395f5] Adds osx example.
@dumganhar
Copy link
Contributor Author

@ocornut , It was DONE.

@ocornut ocornut merged commit b359ed7 into ocornut:master Apr 5, 2016
@ocornut
Copy link
Owner

ocornut commented Apr 5, 2016

Merged, thanks! Also adding link to #247
Note that this is untested, trusting you (but I'm seeing mostly renames here). I yet have to get a development mac.

@ocornut
Copy link
Owner

ocornut commented Apr 5, 2016

Out of curiosity, could you confirm the point of this example running on OS X, when you could use the opengl3_example which is much simpler?

ocornut added a commit that referenced this pull request Apr 5, 2016
@dumganhar
Copy link
Contributor Author

Out of curiosity, could you confirm the point of this example running on OS X, when you could use the opengl3_example which is much simpler?

@ocornut , I linked opengl_example to xcode project for OSX target.

screen shot 2016-04-06 at 10 34 05

Why is opengl3_example simpler than opengl_example?

@dumganhar
Copy link
Contributor Author

@joeld42 said that:

This is the iOS default Xcode "OpenGL" template (which draws two spinning cubes), modified to support iOS and uSynergy. More details in the README.md in the ios_example directory. It's based mainly on the glfw and opengl3 examples. Tested on iOS8 on iPad and iPhone (iPhone works but the screen gets reaallly crowded).

But i didn't see that imguiex-ios depends on glfw & opengl3.
Could @joeld42 also review my changes? :)

@ocornut , Thanks for the merge.

@ocornut
Copy link
Owner

ocornut commented Apr 6, 2016

So basically you added a xcode project over opengl_example, what is the benefit for that?
Could the xcode project be added inside the opengl_example directory and leave the ios/objective-c/synergy alone?

@dumganhar
Copy link
Contributor Author

@ocornut ,it's my experience from Cocos2d-x development,
we often need to debug something on iOS & OSX since we are developing Cross Platform Game Engine.
It isn't comfortable if we maintain iOS & OSX projects separately. That 's my point.
If synergy is only used for iOS, I could update the project and OSX target will not compile those source files only need for iOS. :)

@ocornut
Copy link
Owner

ocornut commented Apr 7, 2016

But that certainly apply to your own project, but you aren't going to use imgui's example projects in your work?
Sorry asking those question, those iOS/Apple folder are the only things in the repository that I'm not testing and it is very alien to me (in addition to being full of weird files).

@dumganhar
Copy link
Contributor Author

But that certainly apply to your own project, but you aren't going to use imgui's example projects in your work?

If a core developer of imguiwants to develop or fix something on OSX, he/she may debug some core functionalities of imgui base on example project. If iOS / OSX projects are separated, he/she should maintain 2 projects and always switch them. It'll be complicated and boring.

So less project configure files, less maintain effort.

ocornut added a commit that referenced this pull request Apr 20, 2016
ocornut added a commit that referenced this pull request Jul 30, 2016
…les (#323)

Missing support Vulkan (#549), Apple (#575, #247), SDL (#58, #356),
Allegro, Marmalade (#368, #375)
ocornut added a commit that referenced this pull request Sep 18, 2017
…les (#323)

Missing support Vulkan (#549), Apple (#575, #247), SDL (#58, #356),
Allegro, Marmalade (#368, #375)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants