-
-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Text undo crash in memmove() from ImGuiStb::stb_textedit_discard_redo #681
Comments
I don't want to highjack this issue, but I get weird exceptions as well, since I updated with all the commits from the last 2 months (havent had time to update before, but back then all was fine ). But the problem is definitly string related. I had to disable the console, else it would randomly crash on opening the console or just later on. I tried to go deeper to find the cause, but it returns from that function fine a few times, then randomly crashes a bit later on. So I would guess something corrupts stack or memory around the stringshandling in |
Reverted back my copy to the commit on 8th Feb. No crashes anymore. |
Thanks for the details and sorry for the delay. Will look into it! |
I am fixing Dale's bug now. Thanks. @MINIONBOTS however I don't know what your issue it and it may be completely unrelated. How do I repro? Please confirm that it crashes in the demo code or provide an explanation/repro of the code or steps to use to see it. It probably needs a new issue as well. Thanks! |
Oh man, such an innocuous line, and yet so wrong... how did this work at all? Hopefully STB knows about this? -Dale Kim |
Yeah it was surprising! I posted it on twitter and github now |
Hi Omar!
Sorry about the lack of details on this report, I'm very busy this week!
We encountered a crash in our game when undoing a bunch of text edits. Initially encountered it on Windows, but also repro'd on Linux.
Repro steps:
Crash on step 2.
Here's the Linux trace:
We are on dear imgui 1.48 release in our game, but I have also repro'd on master 254a1a9 using the OpenGL 2 example.
-Dale Kim
The text was updated successfully, but these errors were encountered: