Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tables branch is broken #3293

Closed
rhard opened this issue Jun 9, 2020 · 5 comments
Closed

Tables branch is broken #3293

rhard opened this issue Jun 9, 2020 · 5 comments

Comments

@rhard
Copy link

rhard commented Jun 9, 2020

Hi @ocornut, just want to let you know that the table rendering is broken since you updated tables branch last time. In the picture below, the background rendering is only visible in the last column.
image

Unfortunately, I can't tell what exactly happening in the tables branch, but previous commit reference is not found on the GitHub anymore. If I try to go back in history, all the commits have the same issue. My local commit reference is still OK.

This is the commit: e69be29 - Tables: Avoid TableGetSortSpecs() having a side-effect on sort specs sanitization.
This is the old (working) reference for the same commit which is not available now: b110e5b

@ocornut
Copy link
Owner

ocornut commented Jun 9, 2020 via email

ocornut added a commit that referenced this issue Jun 10, 2020
…ixes #3163, code was accidently relying on SetCurrentChannel not updating rectangle)

+ Used shortcut in PushTableBackground/PopTableBackground
@ocornut
Copy link
Owner

ocornut commented Jun 10, 2020

@rhard: pushed a fix for it now. Thanks for reporting.
This made me thing of improvements/changes we could do for #3163

@ocornut ocornut closed this as completed Jun 10, 2020
@rhard
Copy link
Author

rhard commented Jun 11, 2020

Thanks! Fixed.

ocornut added a commit that referenced this issue Jun 13, 2020
…ixes #3163, code was accidently relying on SetCurrentChannel not updating rectangle)

+ Used shortcut in PushTableBackground/PopTableBackground
ocornut added a commit that referenced this issue Jun 13, 2020
…t always showing due to unset clip rect.
@ocornut
Copy link
Owner

ocornut commented Jun 13, 2020

I pushed additional changes as the previous work on #3163 and this had further issues.
Always made column change faster now. Hopefully haven't broken anything!

ocornut added a commit that referenced this issue Jun 13, 2020
…ixes #3163, code was accidently relying on SetCurrentChannel not updating rectangle)

+ Used shortcut in PushTableBackground/PopTableBackground
ocornut added a commit that referenced this issue Jun 13, 2020
…t always showing due to unset clip rect.
ocornut added a commit that referenced this issue Jun 16, 2020
…ixes #3163, code was accidently relying on SetCurrentChannel not updating rectangle)

+ Used shortcut in PushTableBackground/PopTableBackground
ocornut added a commit that referenced this issue Jun 16, 2020
…t always showing due to unset clip rect.
ocornut added a commit that referenced this issue Jun 16, 2020
…ixes #3163, code was accidently relying on SetCurrentChannel not updating rectangle)

+ Used shortcut in PushTableBackground/PopTableBackground
ocornut added a commit that referenced this issue Jun 16, 2020
…t always showing due to unset clip rect.
ocornut added a commit that referenced this issue Jun 19, 2020
…ixes #3163, code was accidently relying on SetCurrentChannel not updating rectangle)

+ Used shortcut in PushTableBackground/PopTableBackground
ocornut added a commit that referenced this issue Jun 19, 2020
…t always showing due to unset clip rect.
@rhard
Copy link
Author

rhard commented Jun 20, 2020

I pushed additional changes as the previous work on #3163 and this had further issues.
Always made column change faster now. Hopefully haven't broken anything!

Everything fine until now!

ocornut added a commit that referenced this issue Jun 23, 2020
…ixes #3163, code was accidently relying on SetCurrentChannel not updating rectangle)

+ Used shortcut in PushTableBackground/PopTableBackground
ocornut added a commit that referenced this issue Jun 23, 2020
…t always showing due to unset clip rect.
ocornut added a commit that referenced this issue Jun 29, 2020
…ixes #3163, code was accidently relying on SetCurrentChannel not updating rectangle)

+ Used shortcut in PushTableBackground/PopTableBackground
ocornut added a commit that referenced this issue Jun 29, 2020
…t always showing due to unset clip rect.
ocornut added a commit that referenced this issue Jun 30, 2020
…ixes #3163, code was accidently relying on SetCurrentChannel not updating rectangle)

+ Used shortcut in PushTableBackground/PopTableBackground
ocornut added a commit that referenced this issue Jun 30, 2020
…t always showing due to unset clip rect.
ocornut added a commit that referenced this issue Jul 2, 2020
…ixes #3163, code was accidently relying on SetCurrentChannel not updating rectangle)

+ Used shortcut in PushTableBackground/PopTableBackground
ocornut added a commit that referenced this issue Jul 2, 2020
…t always showing due to unset clip rect.
ocornut added a commit that referenced this issue Jul 8, 2020
…ixes #3163, code was accidently relying on SetCurrentChannel not updating rectangle)

+ Used shortcut in PushTableBackground/PopTableBackground
ocornut added a commit that referenced this issue Jul 8, 2020
…t always showing due to unset clip rect.
ocornut added a commit that referenced this issue Jul 14, 2020
…ixes #3163, code was accidently relying on SetCurrentChannel not updating rectangle)

+ Used shortcut in PushTableBackground/PopTableBackground
ocornut added a commit that referenced this issue Jul 14, 2020
…t always showing due to unset clip rect.
ocornut added a commit that referenced this issue Nov 20, 2020
…ixes #3163, code was accidently relying on SetCurrentChannel not updating rectangle)

+ Used shortcut in PushTableBackground/PopTableBackground
ocornut added a commit that referenced this issue Nov 20, 2020
…t always showing due to unset clip rect.
ocornut added a commit that referenced this issue Nov 30, 2020
…ixes #3163, code was accidently relying on SetCurrentChannel not updating rectangle)

+ Used shortcut in PushTableBackground/PopTableBackground
ocornut added a commit that referenced this issue Nov 30, 2020
…t always showing due to unset clip rect.
rokups pushed a commit to rokups/imgui that referenced this issue Dec 1, 2020
…oken by fixes ocornut#3163, code was accidently relying on SetCurrentChannel not updating rectangle)

+ Used shortcut in PushTableBackground/PopTableBackground
rokups pushed a commit to rokups/imgui that referenced this issue Dec 1, 2020
…zing border not always showing due to unset clip rect.
rokups pushed a commit to rokups/imgui that referenced this issue Dec 1, 2020
…oken by fixes ocornut#3163, code was accidently relying on SetCurrentChannel not updating rectangle)

+ Used shortcut in PushTableBackground/PopTableBackground
rokups pushed a commit to rokups/imgui that referenced this issue Dec 1, 2020
…zing border not always showing due to unset clip rect.
rokups pushed a commit to rokups/imgui that referenced this issue Dec 1, 2020
…oken by fixes ocornut#3163, code was accidently relying on SetCurrentChannel not updating rectangle)

+ Used shortcut in PushTableBackground/PopTableBackground
rokups pushed a commit to rokups/imgui that referenced this issue Dec 1, 2020
…zing border not always showing due to unset clip rect.
rokups pushed a commit to rokups/imgui that referenced this issue Dec 1, 2020
…oken by fixes ocornut#3163, code was accidently relying on SetCurrentChannel not updating rectangle)

+ Used shortcut in PushTableBackground/PopTableBackground
rokups pushed a commit to rokups/imgui that referenced this issue Dec 1, 2020
…zing border not always showing due to unset clip rect.
rokups pushed a commit to rokups/imgui that referenced this issue Dec 1, 2020
…oken by fixes ocornut#3163, code was accidently relying on SetCurrentChannel not updating rectangle)

+ Used shortcut in PushTableBackground/PopTableBackground
rokups pushed a commit to rokups/imgui that referenced this issue Dec 1, 2020
…zing border not always showing due to unset clip rect.
rokups pushed a commit to rokups/imgui that referenced this issue Dec 1, 2020
…oken by fixes ocornut#3163, code was accidently relying on SetCurrentChannel not updating rectangle)

+ Used shortcut in PushTableBackground/PopTableBackground
rokups pushed a commit to rokups/imgui that referenced this issue Dec 1, 2020
…zing border not always showing due to unset clip rect.
rokups pushed a commit to rokups/imgui that referenced this issue Dec 1, 2020
…oken by fixes ocornut#3163, code was accidently relying on SetCurrentChannel not updating rectangle)

+ Used shortcut in PushTableBackground/PopTableBackground
rokups pushed a commit to rokups/imgui that referenced this issue Dec 1, 2020
…zing border not always showing due to unset clip rect.
rokups pushed a commit to rokups/imgui that referenced this issue Dec 1, 2020
…oken by fixes ocornut#3163, code was accidently relying on SetCurrentChannel not updating rectangle)

+ Used shortcut in PushTableBackground/PopTableBackground
rokups pushed a commit to rokups/imgui that referenced this issue Dec 1, 2020
…zing border not always showing due to unset clip rect.
ocornut added a commit that referenced this issue Dec 1, 2020
…ixes #3163, code was accidently relying on SetCurrentChannel not updating rectangle)

+ Used shortcut in PushTableBackground/PopTableBackground
ocornut added a commit that referenced this issue Dec 1, 2020
…t always showing due to unset clip rect.
ocornut added a commit that referenced this issue Dec 2, 2020
…ixes #3163, code was accidently relying on SetCurrentChannel not updating rectangle)

+ Used shortcut in PushTableBackground/PopTableBackground
ocornut added a commit that referenced this issue Dec 2, 2020
…t always showing due to unset clip rect.
ocornut added a commit that referenced this issue Dec 3, 2020
…ixes #3163, code was accidently relying on SetCurrentChannel not updating rectangle)

+ Used shortcut in PushTableBackground/PopTableBackground
ocornut added a commit that referenced this issue Dec 3, 2020
…t always showing due to unset clip rect.
ocornut added a commit that referenced this issue Dec 4, 2020
…ixes #3163, code was accidently relying on SetCurrentChannel not updating rectangle)

+ Used shortcut in PushTableBackground/PopTableBackground
ocornut added a commit that referenced this issue Dec 4, 2020
…t always showing due to unset clip rect.
ocornut added a commit that referenced this issue Dec 4, 2020
…ixes #3163, code was accidently relying on SetCurrentChannel not updating rectangle)

+ Used shortcut in PushTableBackground/PopTableBackground
ocornut added a commit that referenced this issue Dec 4, 2020
…t always showing due to unset clip rect.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants