-
-
Notifications
You must be signed in to change notification settings - Fork 10.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tables branch is broken #3293
Labels
Comments
Apologies, issue comes from yesterday’s push in master and today i rebased tables over master. Will look at it tomorrow!
|
ocornut
added a commit
that referenced
this issue
Jun 10, 2020
…ixes #3163, code was accidently relying on SetCurrentChannel not updating rectangle) + Used shortcut in PushTableBackground/PopTableBackground
Thanks! Fixed. |
ocornut
added a commit
that referenced
this issue
Jun 13, 2020
…ixes #3163, code was accidently relying on SetCurrentChannel not updating rectangle) + Used shortcut in PushTableBackground/PopTableBackground
ocornut
added a commit
that referenced
this issue
Jun 13, 2020
…t always showing due to unset clip rect.
I pushed additional changes as the previous work on #3163 and this had further issues. |
ocornut
added a commit
that referenced
this issue
Jun 13, 2020
…ixes #3163, code was accidently relying on SetCurrentChannel not updating rectangle) + Used shortcut in PushTableBackground/PopTableBackground
ocornut
added a commit
that referenced
this issue
Jun 13, 2020
…t always showing due to unset clip rect.
ocornut
added a commit
that referenced
this issue
Jun 16, 2020
…ixes #3163, code was accidently relying on SetCurrentChannel not updating rectangle) + Used shortcut in PushTableBackground/PopTableBackground
ocornut
added a commit
that referenced
this issue
Jun 16, 2020
…t always showing due to unset clip rect.
ocornut
added a commit
that referenced
this issue
Jun 16, 2020
…ixes #3163, code was accidently relying on SetCurrentChannel not updating rectangle) + Used shortcut in PushTableBackground/PopTableBackground
ocornut
added a commit
that referenced
this issue
Jun 16, 2020
…t always showing due to unset clip rect.
ocornut
added a commit
that referenced
this issue
Jun 19, 2020
…ixes #3163, code was accidently relying on SetCurrentChannel not updating rectangle) + Used shortcut in PushTableBackground/PopTableBackground
ocornut
added a commit
that referenced
this issue
Jun 19, 2020
…t always showing due to unset clip rect.
Everything fine until now! |
ocornut
added a commit
that referenced
this issue
Jun 23, 2020
…ixes #3163, code was accidently relying on SetCurrentChannel not updating rectangle) + Used shortcut in PushTableBackground/PopTableBackground
ocornut
added a commit
that referenced
this issue
Jun 23, 2020
…t always showing due to unset clip rect.
ocornut
added a commit
that referenced
this issue
Jun 29, 2020
…ixes #3163, code was accidently relying on SetCurrentChannel not updating rectangle) + Used shortcut in PushTableBackground/PopTableBackground
ocornut
added a commit
that referenced
this issue
Jun 29, 2020
…t always showing due to unset clip rect.
ocornut
added a commit
that referenced
this issue
Jun 30, 2020
…ixes #3163, code was accidently relying on SetCurrentChannel not updating rectangle) + Used shortcut in PushTableBackground/PopTableBackground
ocornut
added a commit
that referenced
this issue
Jun 30, 2020
…t always showing due to unset clip rect.
ocornut
added a commit
that referenced
this issue
Jul 2, 2020
…ixes #3163, code was accidently relying on SetCurrentChannel not updating rectangle) + Used shortcut in PushTableBackground/PopTableBackground
ocornut
added a commit
that referenced
this issue
Jul 2, 2020
…t always showing due to unset clip rect.
ocornut
added a commit
that referenced
this issue
Jul 8, 2020
…ixes #3163, code was accidently relying on SetCurrentChannel not updating rectangle) + Used shortcut in PushTableBackground/PopTableBackground
ocornut
added a commit
that referenced
this issue
Jul 8, 2020
…t always showing due to unset clip rect.
ocornut
added a commit
that referenced
this issue
Jul 14, 2020
…ixes #3163, code was accidently relying on SetCurrentChannel not updating rectangle) + Used shortcut in PushTableBackground/PopTableBackground
ocornut
added a commit
that referenced
this issue
Jul 14, 2020
…t always showing due to unset clip rect.
ocornut
added a commit
that referenced
this issue
Nov 20, 2020
…ixes #3163, code was accidently relying on SetCurrentChannel not updating rectangle) + Used shortcut in PushTableBackground/PopTableBackground
ocornut
added a commit
that referenced
this issue
Nov 20, 2020
…t always showing due to unset clip rect.
ocornut
added a commit
that referenced
this issue
Nov 30, 2020
…ixes #3163, code was accidently relying on SetCurrentChannel not updating rectangle) + Used shortcut in PushTableBackground/PopTableBackground
ocornut
added a commit
that referenced
this issue
Nov 30, 2020
…t always showing due to unset clip rect.
rokups
pushed a commit
to rokups/imgui
that referenced
this issue
Dec 1, 2020
…oken by fixes ocornut#3163, code was accidently relying on SetCurrentChannel not updating rectangle) + Used shortcut in PushTableBackground/PopTableBackground
rokups
pushed a commit
to rokups/imgui
that referenced
this issue
Dec 1, 2020
…zing border not always showing due to unset clip rect.
rokups
pushed a commit
to rokups/imgui
that referenced
this issue
Dec 1, 2020
…oken by fixes ocornut#3163, code was accidently relying on SetCurrentChannel not updating rectangle) + Used shortcut in PushTableBackground/PopTableBackground
rokups
pushed a commit
to rokups/imgui
that referenced
this issue
Dec 1, 2020
…zing border not always showing due to unset clip rect.
rokups
pushed a commit
to rokups/imgui
that referenced
this issue
Dec 1, 2020
…oken by fixes ocornut#3163, code was accidently relying on SetCurrentChannel not updating rectangle) + Used shortcut in PushTableBackground/PopTableBackground
rokups
pushed a commit
to rokups/imgui
that referenced
this issue
Dec 1, 2020
…zing border not always showing due to unset clip rect.
rokups
pushed a commit
to rokups/imgui
that referenced
this issue
Dec 1, 2020
…oken by fixes ocornut#3163, code was accidently relying on SetCurrentChannel not updating rectangle) + Used shortcut in PushTableBackground/PopTableBackground
rokups
pushed a commit
to rokups/imgui
that referenced
this issue
Dec 1, 2020
…zing border not always showing due to unset clip rect.
rokups
pushed a commit
to rokups/imgui
that referenced
this issue
Dec 1, 2020
…oken by fixes ocornut#3163, code was accidently relying on SetCurrentChannel not updating rectangle) + Used shortcut in PushTableBackground/PopTableBackground
rokups
pushed a commit
to rokups/imgui
that referenced
this issue
Dec 1, 2020
…zing border not always showing due to unset clip rect.
rokups
pushed a commit
to rokups/imgui
that referenced
this issue
Dec 1, 2020
…oken by fixes ocornut#3163, code was accidently relying on SetCurrentChannel not updating rectangle) + Used shortcut in PushTableBackground/PopTableBackground
rokups
pushed a commit
to rokups/imgui
that referenced
this issue
Dec 1, 2020
…zing border not always showing due to unset clip rect.
rokups
pushed a commit
to rokups/imgui
that referenced
this issue
Dec 1, 2020
…oken by fixes ocornut#3163, code was accidently relying on SetCurrentChannel not updating rectangle) + Used shortcut in PushTableBackground/PopTableBackground
rokups
pushed a commit
to rokups/imgui
that referenced
this issue
Dec 1, 2020
…zing border not always showing due to unset clip rect.
rokups
pushed a commit
to rokups/imgui
that referenced
this issue
Dec 1, 2020
…oken by fixes ocornut#3163, code was accidently relying on SetCurrentChannel not updating rectangle) + Used shortcut in PushTableBackground/PopTableBackground
rokups
pushed a commit
to rokups/imgui
that referenced
this issue
Dec 1, 2020
…zing border not always showing due to unset clip rect.
ocornut
added a commit
that referenced
this issue
Dec 1, 2020
…ixes #3163, code was accidently relying on SetCurrentChannel not updating rectangle) + Used shortcut in PushTableBackground/PopTableBackground
ocornut
added a commit
that referenced
this issue
Dec 1, 2020
…t always showing due to unset clip rect.
ocornut
added a commit
that referenced
this issue
Dec 2, 2020
…ixes #3163, code was accidently relying on SetCurrentChannel not updating rectangle) + Used shortcut in PushTableBackground/PopTableBackground
ocornut
added a commit
that referenced
this issue
Dec 2, 2020
…t always showing due to unset clip rect.
ocornut
added a commit
that referenced
this issue
Dec 3, 2020
…ixes #3163, code was accidently relying on SetCurrentChannel not updating rectangle) + Used shortcut in PushTableBackground/PopTableBackground
ocornut
added a commit
that referenced
this issue
Dec 3, 2020
…t always showing due to unset clip rect.
ocornut
added a commit
that referenced
this issue
Dec 4, 2020
…ixes #3163, code was accidently relying on SetCurrentChannel not updating rectangle) + Used shortcut in PushTableBackground/PopTableBackground
ocornut
added a commit
that referenced
this issue
Dec 4, 2020
…t always showing due to unset clip rect.
ocornut
added a commit
that referenced
this issue
Dec 4, 2020
…ixes #3163, code was accidently relying on SetCurrentChannel not updating rectangle) + Used shortcut in PushTableBackground/PopTableBackground
ocornut
added a commit
that referenced
this issue
Dec 4, 2020
…t always showing due to unset clip rect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi @ocornut, just want to let you know that the table rendering is broken since you updated tables branch last time. In the picture below, the background rendering is only visible in the last column.
Unfortunately, I can't tell what exactly happening in the tables branch, but previous commit reference is not found on the GitHub anymore. If I try to go back in history, all the commits have the same issue. My local commit reference is still OK.
This is the commit: e69be29 - Tables: Avoid TableGetSortSpecs() having a side-effect on sort specs sanitization.
This is the old (working) reference for the same commit which is not available now: b110e5b
The text was updated successfully, but these errors were encountered: