Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[370] Add a getAllEnvelopes method to the event-stores #371

Merged
merged 11 commits into from
Oct 17, 2024

Conversation

drieshooghe
Copy link
Member

  • ♻️ rename getLastAggregateEnvelopes to getLastEnvelopesForAggregate
  • ♻️ rename fromId parameters to aggregateId
  • ♻️ rename getManyLastSnapshots to getLastSnapshots
  • ✨ add a getAllEnvelopes method to the abstract event-store
  • ✅ update tests to assert the getAllEnvelopes method on all event-stores
  • ✨ add a separate filter for fetching all events
  • 🗃️ add additional indices and add a getAllEnvelopes method to each event-store

Description

  • renames some methods
  • adds a getAllEnvelopes method to all event-stores
  • adjusts the indices to match that logic

Fixes #370

@drieshooghe drieshooghe self-assigned this Oct 17, 2024
Copy link

changeset-bot bot commented Oct 17, 2024

🦋 Changeset detected

Latest commit: 983f757

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@ocoda/event-sourcing-dynamodb Major
@ocoda/event-sourcing-postgres Major
@ocoda/event-sourcing-mariadb Major
@ocoda/event-sourcing-mongodb Major
@ocoda/event-sourcing Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 17, 2024
@drieshooghe drieshooghe force-pushed the 370-add-a-get-all-event-envelopes-method branch from a71794e to 90e55c6 Compare October 17, 2024 11:19
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

Attention: Patch coverage is 95.58011% with 8 lines in your changes missing coverage. Please review.

Project coverage is 94.42%. Comparing base (b8613a2) to head (983f757).
Report is 12 commits behind head on master.

Files with missing lines Patch % Lines
...b/integration/event-store/in-memory.event-store.ts 92.85% 2 Missing ⚠️
...ges/integration/mariadb/lib/mariadb.event-store.ts 92.59% 2 Missing ⚠️
packages/core/lib/event-store.ts 93.33% 1 Missing ⚠️
...s/integration/dynamodb/lib/dynamodb.event-store.ts 96.15% 1 Missing ⚠️
...ges/integration/mongodb/lib/mongodb.event-store.ts 95.23% 1 Missing ⚠️
...s/integration/postgres/lib/postgres.event-store.ts 96.29% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #371      +/-   ##
==========================================
+ Coverage   94.27%   94.42%   +0.14%     
==========================================
  Files         107      107              
  Lines        2253     2366     +113     
  Branches      481      508      +27     
==========================================
+ Hits         2124     2234     +110     
- Misses        129      132       +3     
Flag Coverage Δ
core 92.58% <94.54%> (+0.06%) ⬆️
integrations 96.14% <96.03%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...gration/snapshot-store/in-memory.snapshot-store.ts 97.27% <100.00%> (+0.03%) ⬆️
packages/core/lib/models/ulid.ts 100.00% <100.00%> (ø)
packages/core/lib/snapshot-repository.ts 93.02% <100.00%> (-0.32%) ⬇️
packages/core/lib/snapshot-store.ts 100.00% <100.00%> (ø)
...ntegration/dynamodb/lib/dynamodb.snapshot-store.ts 96.59% <100.00%> (+0.01%) ⬆️
.../integration/mariadb/lib/mariadb.snapshot-store.ts 91.35% <100.00%> (+0.05%) ⬆️
.../integration/mongodb/lib/mongodb.snapshot-store.ts 97.93% <100.00%> (+0.01%) ⬆️
...ntegration/postgres/lib/postgres.snapshot-store.ts 98.17% <100.00%> (+0.01%) ⬆️
packages/core/lib/event-store.ts 96.96% <93.33%> (-3.04%) ⬇️
...s/integration/dynamodb/lib/dynamodb.event-store.ts 96.02% <96.15%> (+0.57%) ⬆️
... and 4 more

@drieshooghe drieshooghe merged commit b4039b7 into master Oct 17, 2024
27 checks passed
@drieshooghe drieshooghe deleted the 370-add-a-get-all-event-envelopes-method branch October 17, 2024 11:39
@github-actions github-actions bot mentioned this pull request Oct 17, 2024
@drieshooghe drieshooghe added enhancement New feature or request packages Pull request that changes functionality and removed documentation Improvements or additions to documentation labels Oct 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request packages Pull request that changes functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a getAllEnvelopes method to the event-stores
1 participant