chore(deps): update dependency rome to v12 #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
renovate
bot
force-pushed
the
renovate/rome-12.x
branch
from
1368a4a
to
ec856c7
Compare
renovate
bot
force-pushed
the
renovate/rome-12.x
branch
2 times, most recently
from
f2cff15
to
9dda606
Compare
renovate
bot
force-pushed
the
renovate/rome-12.x
branch
2 times, most recently
from
6278db1
to
d61d163
Compare
drieshooghe
force-pushed
the
renovate/rome-12.x
branch
from
d61d163
to
bb37fa7
Compare
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. ⚠ Warning: custom changes will be lost. |
Codecov Report
@@ Coverage Diff @@
## master #136 +/- ##
==========================================
- Coverage 91.41% 91.39% -0.02%
==========================================
Files 90 90
Lines 1374 1372 -2
Branches 280 278 -2
==========================================
- Hits 1256 1254 -2
Misses 114 114
Partials 4 4
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
10.0.1->12.1.3Release Notes
rome/tools
v12.1.3CLI
Other changes
rome lsp-proxyshould accept the global CLI options #4505Configuration
Other changes
nurserywere enabled when the"nursery": {}objectwas defined #4479
Formatter
Linter
Other changes
useHookAtTopLevelcaused to returning call expressions of a hook.Parser
Other changes
v12.1.2Configuration
Other changes
the correct rules to apply #4502
Linter
New rules
noUselessTypeConstraintOther changes
noInnerDeclarations: allow function declarations in nested block inside an ES module #4492.noInvalidConstructorSuper: recognizeextendsclauses that use static member access such asextends mod.C#4499v12.1.1CLI
Other changes
lsp-proxywas renamedlsp_proxy#4489Configuration
Other changes
Linter
Other changes
noAssignInExpressionsrule replaced the operator with an invalid token, which caused other lint rules to crash. #4464noUnusedVariablesrule did not correctly detect exports when a variable and aninterfacehad the same name #4468v12.1.0CLI
Other changes
output. #4405.
rome checkcan accept input fromstdin.--stdin-file-pathto use when runningrome checkviastdin.--formatter-enabledto the commandrome checkto control the formatter via CLI.--linter-enabledto the commandrome checkto control the linter via CLI.--organize-imports-enabledto the commandrome checkto control the import sorting via CLI.rome migratethe transform the configuration filerome.jsonwhen there are breaking changes.
Configuration
vcsproperty, to opt in the VCS integration:vcs.enabled, to enable or not the integration;vcs.clientKind, the supported clients;vcs.useIgnoreFile, to ignore the files/paths inside the file;vcs.root, an optional path to the root of the VCS;Editors
Other changes
Formatter
Other changes
lineWidthfor arrays #4351Linter
New rules
noConfusingArrownoRedundantRolesnoNoninteractiveTabindexnoAriaUnsupportedElementsnoConsoleLognoForEachuseLiteralKeysnoConstantConditionuseGroupedTypeImportnoUselessConstructoruseLiteralEnumMembersuseHeadingContentnoAccumulatingSpreaduseSimpleNumberKeysPromoted rules
New rules are promoted, please check #4431 for more details.
Note that,
noExtraSemicolonsandnoExtraLabelsare renamed tonoExtraSemicolonandnoUselessLabel.Other changes
the code action is not formatted.
useShorthandArrayTyperule did not handle nested ReadonlyArray types correctly and erroneously reported TsObjectType #4354.noUndeclaredVariablesdetects globals based on the file type.noUndeclaredVariablesincorrectly identifiesAggregateErroras an undeclared variable. #4365useLiteralKeysrule doesn't ignore valid uses of square bracket notation. #4370noNonNullAssertionto emit incorrect code actionuseButtonTypeto miss some casesuseCamelCasecaused to default exported componentsuseCamelCasecaused to private class membersuseHookAtTopLevelcaused to arrow functions, export default functions and function expressions.useHookAtTopLevelcaused toasorsatisfiesexpression.noHeadeScopecaused to custom componentsnoNoninteractiveElementToInteractiveRoleandnoNoninteractiveTabindexcaused to non-interactive elements.Parser
Other changes
ctsfilesexportandexport default. #4252VSCode
requireConfigurationis set totrueby defaultv12.0.0CLI
Breaking changes
While this change is a bug fix, this could affect how the
ignoreentries are defined inside a project. We suggest to review themand make sure they still work.
--apply-suggestedis now called--apply-unsaferome check --applyandrome check --apply-unsafeexits with non-zero code (error code)if there are still diagnostics to be addressed.
Other changes
rome checknow checks import statements. This is an experimental feature that needs to beenabled via configuration. Import can be sorted using
rome check --apply-unsafeworking directory, it will try to find one in the parent directories.
--config-path. It tells Rome to try and discover arome.jsonfilein the given path.
Configuration
Other changes
exit anymore if there are issues with the
rome.jsonfile, instead it will apply its defaultsto the sections that are incorrect.
javascript.organizeImports. This is an experimental feature and users need to opt-in.{ "organizeImports": { "enabled": true, "ignore": ["trickyFile.js"] } }linter.rules.allandlinter.rules.[group].all. These options allow to enable or disable allrules, or all rules for a given group.
allandrecommendedcan't be bothtrue.{ "linter": { "rules": { "all": true, "style" : { "all": false } } } }The previous example will enable all rules and disable all rules that belong to the
stylegroup.Editors
Other changes
rome.jsonfile.Formatter
Linter
New rules are promoted, please check #4239 for more
details.
Parser
VSCode
Other changes
requireConfiguration. Enabling this option will force Rome to requirea configuration file in your workspace/project. If Rome doesn't find a
rome.jsonfile, it won'temit diagnostics.
v11.0.0CLI
BREAKING CHANGES
--no-colorshas been removed, in favor of--color=offOther changes
initcommand now adds the$schemaproperty to the generatedrome.jsonfileif
romeis installed inside thenode_modulesfolder. Follow this guide to add the$schemapropertymanually in a project with an existing
rome.jsonfile.--semicolonsoption that configures if the formatter prints semicolons at the end of every statement (default) or at the beginning of statements when necessary to prevent ASI failures.Rome now prints the total number of errors caused in the files.
--colorsoption with the valueforce. Forcing color output can be useful if you spawn Rome as a subprocess.Rome is spawned as a process;
Configuration
$schemaproperty. The schema enables auto-completion by editors and...auto-completion and descriptions of all fields of the configuration file.
files.ignoreoption where users can ignore files across tools.Editors
node_modulesfolder.Formatter
BREAKING CHANGES
jestEachtemplatesOther changes
Linter
noUselessFragments#3668noArrayIndexKeywhere some cases were not detected #3670noConstAssign#3728noShoutyConstants#3867noUnusedVariables#3779noUndeclaredVariableswhere some cases were not detected #3798noUndeclaredVariableswhere types were incorrectly detected #3669Rules
The following rules have been stabilized:
nursery/useFlatMap->complexity/useFlatMapnursery/useValidForDirection->correctness/useValidForDirectionnursery/noExplicitAny->suspicious/noExplicitAnynursery/noConstAssign->correctness/noConstAssignThese rules are all recommended, so they will be enabled by default. You can simply remove those entries from your configuration file if you had enabled them manually from the
nurserygroup.The following rules have been renamed:
a11y/useBlankTarget->a11y/noBlankTargetcorrectness/noMultipleSpacesInRegularExpressionLiterals->complexity/noMultipleSpacesInRegularExpressionLiteralsstyle/useOptionalChain->complexity/useOptionalChaincorrectness/noUselessFragments->complexity/noUselessFragmentscorrectness/noDelete->performance/noDeletecorrectness/useSingleCaseStatement->style/useSingleCaseStatementcorrectness/useWhile->style/useWhilecorrectness/noArguments->style/noArgumentscorrectness/noAsyncPromiseExecutor->suspicious/noAsyncPromiseExecutorcorrectness/noCommentText->suspicious/noCommentTextcorrectness/noCompareNegZero->suspicious/noCompareNegZerocorrectness/noDebugger->suspicious/noDebuggercorrectness/noDoubleEquals->suspicious/noDoubleEqualscorrectness/noShadowRestrictedNames->suspicious/noShadowRestrictedNamescorrectness/noSparseArray->suspicious/noSparseArraycorrectness/noUnsafeNegation->suspicious/noUnsafeNegationcorrectness/useValidTypeof->suspicious/useValidTypeofcorrectness/noArrayIndexKey->suspicious/noArrayIndexKeycorrectness/noCatchAssign->suspicious/noCatchAssigncorrectness/noDupeArgs->suspicious/noDuplicateParameterscorrectness/noFunctionAssign->suspicious/noFunctionAssigncorrectness/noImportAssign->suspicious/noImportAssigncorrectness/noLabelVar->suspicious/noLabelVarcorrectness/noRestrictedGlobals->nursery/noRestrictedGlobalsnursery/noDupeKeys->nursery/noDuplicateObjectKeysIf you were not changing the severity level of any of these rules in your configuration file, or suppressing a diagnostic emitted by those rules using suppression comments, you do not have to do anything. But if you did, Rome will now emit diagnostics for the parts of your configuration or suppression comments you need to update.
The following rules are no longer recommended:
style/noImplicitBooleanstyle/noNegationElsestyle/useBlockStatementsstyle/useShorthandArrayTypecorrectness/useSingleCaseStatement/style/useSingleCaseStatementstyle/noShoutyConstantsThe styling decisions imposed by these rules were not deemed to be idiomatic enough in the JavaScript ecosystem to be enabled by default. If you do want to enforce those rules in your project, you will have to enable them manually in you configuration file:
{ "linter": { "rules": { "style": { "useBlockStatements": "warn" } } } }Finally, the following new rules have been introduced to the nursery group in this release:
nursery/noAccessKeynursery/noConditionalAssignmentnursery/noConstEnumnursery/noConstructorReturnnursery/noDistractingElementsnursery/noDuplicateObjectKeysnursery/noEmptyInterfacenursery/noExtraNonNullAssertionnursery/noHeaderScopenursery/noNonNullAssertionnursery/noPrecisionLossnursery/noRedundantUseStrictnursery/noSetterReturnnursery/noStringCaseMismatchnursery/noUnsafeFinallynursery/noVoidTypeReturnnursery/useDefaultSwitchClauseLastnursery/useNumericLiteralsnursery/useAriaPropTypesnursery/useAriaPropsForRolenursery/noVarnursery/useConstPlease give them a try by manually enabling them in your configuration and please share your feedback on the rule, diagnostics, and code fixes.
Parser
JSON;satisfieskeyword;asyncused as label #3612export default functionind.tsfiles #3485awaitin non-async contexts #2479VSCode
JavaScript APIs
Breaking change
backendhas been removed, in favor of the concept ofdistribution.Other changes
Configuration
📅 Schedule: Branch creation - "before 5am on monday" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.