fix: override stdout rows to prevent terminal clearing #27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent prior output from being cleared
ink clears the terminal when the height of the output exceeds the height of the terminal. This means that any output in the terminal prior to the rendering of the table is removed. So to prevent this, we override the number of rows on the stdout stream so that the height of the terminal is always greater than the height of the table.
This should be fine since the table is only rendered once.
Windows tests run by
wireit
For some unknown reason using our wrapper stream on windows is problematic when tests are run by
wireit
. To avoid this, we detect this situation and useprocess.stdout
instead