Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the S3 file structure #22

Closed
mcurcio opened this issue Jun 13, 2018 · 8 comments
Closed

Document the S3 file structure #22

mcurcio opened this issue Jun 13, 2018 · 8 comments

Comments

@mcurcio
Copy link

mcurcio commented Jun 13, 2018

Pardon me if this plugin is not ready for public consumption...

As far as I can tell, dev pack alone does not produce the correct directory structure to sync with S3. The Heroku CLI does some extra magic to add channel folders. What is the proper way to make the magic happen? Ideally I suppose pack/publish should incorporate channels (somehow?), but I was hoping for an expert take on the roadmap here.

@jdx
Copy link
Contributor

jdx commented Jun 13, 2018

The directory structure should be compatible with the update plugin out of the box. The paths are defined (and overridable in package.json) here: https://github.com/oclif/config/blob/master/src/config.ts#L205-L221

The update plugin will also use these same paths so you can have any structure you like.

Yes, this should be documented but I'm not sure the best place for it. I feel adding it to the release section of the docs would be adding too much detail.

@jdx
Copy link
Contributor

jdx commented Jun 13, 2018

Also, the Heroku CLI uses these defaults so you should be getting exactly the same thing.

@mcurcio
Copy link
Author

mcurcio commented Jun 13, 2018

Thanks for the prompt response. How would one define a channel when running pack and/or publish?

@jdx
Copy link
Contributor

jdx commented Jun 13, 2018

you set the version to something like 1.0.0-beta and then the channel will be beta

@mcurcio
Copy link
Author

mcurcio commented Jun 13, 2018

Well that makes a lot of sense. I guess I was just overthinking it based on the Heroku CLI scripts.

@jdx
Copy link
Contributor

jdx commented Jun 13, 2018

Still, I don't think this is documented anywhere. I'll see if I can add that somewhere

@jdx
Copy link
Contributor

jdx commented Jun 13, 2018

thoughts? oclif/oclif.github.io@829f4ed

@mcurcio
Copy link
Author

mcurcio commented Jun 13, 2018

That looks great. I would suggest noting that the version change occurs in the package.json file (as opposed to, say, a command line flag).

@jdx jdx closed this as completed Jun 13, 2018
sumwatshade added a commit to intuit/plugin-update that referenced this issue Jan 7, 2022
fix: add success msg + fix tar ext
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants