feat!: use npm for plugin operations

docs/plugins.md

@@ -4,10 +4,10 @@ List installed plugins.
 
 - [`mycli plugins`](#mycli-plugins)
 - [`mycli plugins:inspect PLUGIN...`](#mycli-pluginsinspect-plugin)
-- [`mycli plugins:install PLUGIN...`](#mycli-pluginsinstall-plugin)
-- [`mycli plugins:link PLUGIN`](#mycli-pluginslink-plugin)
+- [`mycli plugins install PLUGIN`](#mycli-plugins-install-plugin)
+- [`mycli plugins link PATH`](#mycli-plugins-link-path)
 - [`mycli plugins reset`](#mycli-plugins-reset)
-- [`mycli plugins:uninstall PLUGIN...`](#mycli-pluginsuninstall-plugin)
+- [`mycli plugins uninstall [PLUGIN]`](#mycli-plugins-uninstall-plugin)
 - [`mycli plugins update`](#mycli-plugins-update)
 
 ## `mycli plugins`
@@ -31,7 +31,7 @@ EXAMPLES
   $ mycli plugins
 ```
 
-_See code: [src/commands/plugins/index.ts](https://github.com/oclif/plugin-plugins/blob/4.3.9/src/commands/plugins/index.ts)_
+_See code: [src/commands/plugins/index.ts](https://github.com/oclif/plugin-plugins/blob/4.3.10-beta.0/src/commands/plugins/index.ts)_
 
 ## `mycli plugins:inspect PLUGIN...`
 
@@ -58,59 +58,64 @@ EXAMPLES
   $ mycli plugins inspect myplugin
 ```
 
-_See code: [src/commands/plugins/inspect.ts](https://github.com/oclif/plugin-plugins/blob/4.3.9/src/commands/plugins/inspect.ts)_
+_See code: [src/commands/plugins/inspect.ts](https://github.com/oclif/plugin-plugins/blob/4.3.10-beta.0/src/commands/plugins/inspect.ts)_
 
-## `mycli plugins:install PLUGIN...`
+## `mycli plugins install PLUGIN`
 
-Installs a plugin into the CLI.
+Installs a plugin into mycli.
 
 ```
 USAGE
-  $ mycli plugins install PLUGIN...
+  $ mycli plugins install PLUGIN... [--json] [-f] [-h] [-s | -v]
 
 ARGUMENTS
   PLUGIN...  Plugin to install.
 
 FLAGS
-  -f, --force    Run yarn install with force flag.
+  -f, --force    Force npm to fetch remote resources even if a local copy exists on disk.
   -h, --help     Show CLI help.
-  -s, --silent   Silences yarn output.
-  -v, --verbose  Show verbose yarn output.
+  -s, --silent   Silences npm output.
+  -v, --verbose  Show verbose npm output.
 
 GLOBAL FLAGS
   --json  Format output as json.
 
 DESCRIPTION
-  Installs a plugin into the CLI.
-  Can be installed from npm or a git url.
+  Installs a plugin into mycli.
 
-  Installation of a user-installed plugin will override a core plugin.
+  Uses bundled npm executable to install plugins into /home/runner/.local/share/@oclif/plugin-plugins
 
-  e.g. If you have a core plugin that has a 'hello' command, installing a user-installed plugin with a 'hello' command
-  will override the core plugin implementation. This is useful if a user needs to update core plugin functionality in
-  the CLI without the need to patch and update the whole CLI.
+  Installation of a user-installed plugin will override a core plugin.
 
+  Use the MYCLI_NPM_LOG_LEVEL environment variable to set the npm loglevel.
+  Use the MYCLI_NPM_REGISTRY environment variable to set the npm registry.
 
 ALIASES
   $ mycli plugins add
 
 EXAMPLES
-  $ mycli plugins install myplugin
+  Install a plugin from npm registry.
+
+    $ mycli plugins install myplugin
+
+  Install a plugin from a github url.
+
+    $ mycli plugins install https://github.com/someuser/someplugin
 
-  $ mycli plugins install https://github.com/someuser/someplugin
+  Install a plugin from a github slug.
 
-  $ mycli plugins install someuser/someplugin
+    $ mycli plugins install someuser/someplugin
 ```
 
-_See code: [src/commands/plugins/install.ts](https://github.com/oclif/plugin-plugins/blob/4.3.9/src/commands/plugins/install.ts)_
+_See code: [src/commands/plugins/install.ts](https://github.com/oclif/plugin-plugins/blob/4.3.10-beta.0/src/commands/plugins/install.ts)_
 
-## `mycli plugins:link PLUGIN`
+## `mycli plugins link PATH`
 
 Links a plugin into the CLI for development.
 
 ```
 USAGE
-  $ mycli plugins link PLUGIN
+  $ mycli plugins link PATH [-h] [--install] [-v]
 
 ARGUMENTS
   PATH  [default: .] path to plugin
@@ -132,7 +137,7 @@ EXAMPLES
   $ mycli plugins link myplugin
 ```
 
-_See code: [src/commands/plugins/link.ts](https://github.com/oclif/plugin-plugins/blob/4.3.9/src/commands/plugins/link.ts)_
+_See code: [src/commands/plugins/link.ts](https://github.com/oclif/plugin-plugins/blob/4.3.10-beta.0/src/commands/plugins/link.ts)_
 
 ## `mycli plugins reset`
 
@@ -147,15 +152,15 @@ FLAGS
   --reinstall  Reinstall all plugins after uninstalling.
 ```
 
-_See code: [src/commands/plugins/reset.ts](https://github.com/oclif/plugin-plugins/blob/4.3.9/src/commands/plugins/reset.ts)_
+_See code: [src/commands/plugins/reset.ts](https://github.com/oclif/plugin-plugins/blob/4.3.10-beta.0/src/commands/plugins/reset.ts)_
 
-## `mycli plugins:uninstall PLUGIN...`
+## `mycli plugins uninstall [PLUGIN]`
 
 Removes a plugin from the CLI.
 
 ```
 USAGE
-  $ mycli plugins uninstall PLUGIN...
+  $ mycli plugins uninstall [PLUGIN...] [-h] [-v]
 
 ARGUMENTS
   PLUGIN...  plugin to uninstall
@@ -175,7 +180,7 @@ EXAMPLES
   $ mycli plugins uninstall myplugin
 ```
 
-_See code: [src/commands/plugins/uninstall.ts](https://github.com/oclif/plugin-plugins/blob/4.3.9/src/commands/plugins/uninstall.ts)_
+_See code: [src/commands/plugins/uninstall.ts](https://github.com/oclif/plugin-plugins/blob/4.3.10-beta.0/src/commands/plugins/uninstall.ts)_
 
 ## `mycli plugins update`
 
@@ -193,4 +198,4 @@ DESCRIPTION
   Update installed plugins.
 ```
 
-_See code: [src/commands/plugins/update.ts](https://github.com/oclif/plugin-plugins/blob/4.3.9/src/commands/plugins/update.ts)_
+_See code: [src/commands/plugins/update.ts](https://github.com/oclif/plugin-plugins/blob/4.3.10-beta.0/src/commands/plugins/update.ts)_

package.json

@@ -1,19 +1,18 @@
 {
   "name": "@oclif/plugin-plugins",
   "description": "plugins plugin for oclif",
-  "version": "4.3.9",
+  "version": "5.0.0-beta.6",
   "author": "Salesforce",
   "bugs": "https://github.com/oclif/plugin-plugins/issues",
   "dependencies": {
     "@oclif/core": "^3.25.2",
     "chalk": "^5.3.0",
     "debug": "^4.3.4",
     "npm": "10.5.0",
-    "npm-run-path": "^4.0.1",
+    "npm-package-arg": "^11.0.1",
+    "npm-run-path": "^5.2.0",
     "semver": "^7.6.0",
-    "shelljs": "^0.8.5",
-    "validate-npm-package-name": "^5.0.0",
-    "yarn": "^1.22.21"
+    "validate-npm-package-name": "^5.0.0"
   },
   "devDependencies": {
     "@commitlint/config-conventional": "^18",
@@ -23,6 +22,7 @@
     "@types/debug": "^4.1.12",
     "@types/mocha": "^10.0.6",
     "@types/node": "^18",
+    "@types/npm-package-arg": "^6.1.4",
     "@types/semver": "^7.5.8",
     "@types/shelljs": "^0.8.15",
     "@types/sinon": "^17",
@@ -50,8 +50,7 @@
   "files": [
     "oclif.manifest.json",
     "/lib",
-    "npm-shrinkwrap.json",
-    "oclif.lock"
+    "npm-shrinkwrap.json"
   ],
   "homepage": "https://github.com/oclif/plugin-plugins",
   "keywords": [
@@ -77,15 +76,15 @@
   "repository": "oclif/plugin-plugins",
   "scripts": {
     "build": "shx rm -rf lib && tsc",
-    "clean": "shx rm -f oclif.manifest.json npm-shrinkwrap.json oclif.lock",
+    "clean": "shx rm -f oclif.manifest.json npm-shrinkwrap.json",
     "compile": "tsc",
     "lint": "eslint . --ext .ts",
     "postpack": "yarn run clean",
     "posttest": "yarn lint",
-    "prepack": "yarn build && oclif manifest && oclif readme && npm shrinkwrap && oclif lock",
+    "prepack": "yarn build && oclif manifest && oclif readme && npm shrinkwrap",
     "prepare": "husky && yarn build",
     "pretest": "yarn build --noEmit && tsc -p test --noEmit",
-    "test:integration:install": "mocha \"test/**/install.integration.ts\"",
+    "test:integration:install": "mocha \"test/**/install.integration.ts\" --timeout 1200000",
     "test:integration:link": "mocha \"test/**/link.integration.ts\"",
     "test:integration:sf": "mocha \"test/**/sf.integration.ts\"",
     "test:integration": "mocha \"test/**/*.integration.ts\"",

src/commands/plugins/index.ts

@@ -17,10 +17,14 @@ export default class PluginsIndex extends Command {
     core: Flags.boolean({description: 'Show core plugins.'}),
   }
 
-  plugins = new Plugins(this.config)
+  plugins!: Plugins
 
   async run(): Promise<PluginsJson> {
     const {flags} = await this.parse(PluginsIndex)
+    this.plugins = new Plugins({
+      config: this.config,
+    })
+
     let plugins = this.config.getPluginsList()
     sortBy(plugins, (p) => this.plugins.friendlyName(p.name))
     if (!flags.core) {

src/commands/plugins/inspect.ts

@@ -3,6 +3,7 @@ import chalk from 'chalk'
 import {readFile} from 'node:fs/promises'
 import {dirname, join, sep} from 'node:path'
 
+import {determineLogLevel} from '../../log-level.js'
 import Plugins from '../../plugins.js'
 import {sortBy} from '../../util.js'
 
@@ -59,7 +60,7 @@ export default class PluginsInspect extends Command {
 
   static usage = 'plugins:inspect PLUGIN...'
 
-  plugins = new Plugins(this.config)
+  plugins!: Plugins
 
   async findDep(plugin: Plugin, dependency: string): Promise<{pkgPath: null | string; version: null | string}> {
     const dependencyPath = join(...dependency.split('/'))
@@ -140,7 +141,10 @@ export default class PluginsInspect extends Command {
   /* eslint-disable no-await-in-loop */
   async run(): Promise<PluginWithDeps[]> {
     const {argv, flags} = await this.parse(PluginsInspect)
-    if (flags.verbose) this.plugins.verbose = true
+    this.plugins = new Plugins({
+      config: this.config,
+      logLevel: determineLogLevel(this.config, flags, 'silent'),
+    })
     const aliases = this.config.pjson.oclif.aliases ?? {}
     const plugins: PluginWithDeps[] = []
     for (let name of argv as string[]) {