fix: validate plugin name before install #597
Conversation
| return {name, tag, type: 'npm'} | ||
| } | ||
| } | ||
|
|
||
| function validateNpmPkgName(name:string): void { | ||
| if (!validate(name).validForNewPackages) { |
There was a problem hiding this comment.
I'm looking at the npm docs https://github.com/npm/validate-npm-package-name#legacy-names
I can't tell how far in time you'd have to go to hit an "old name"
What do you think the chances are that someone using oclif has an npm package that violates the new rules (ex: has a Capital letter in it)?
For safety, I'd consider doing this
- make this a major version bump
- since we're doing a major anyway, this is a good time to bump
pjson.enginesto 16+
then we can bump this in our CLIs and most oclif CLIs could, too, unless they happen to need some old-npm -named-plugin?
There was a problem hiding this comment.
I found this issue from 2013, which is before oclif was released:
npm/npm#3914
Not sure about any other legacy rule, let's do a new major 👍🏼
QA notesusing ✅ throws on a bad package name |
Fixes: #594
Use
validate-npm-package-nameto validate the plugin name is a valid npm pkg name before doing any initialization.https://github.com/npm/validate-npm-package-name
@W-13099057@