Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove TS compile step for linked plugins #569

Merged
merged 1 commit into from
Mar 16, 2023
Merged

fix: remove TS compile step for linked plugins #569

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions src/plugins.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,14 +154,6 @@ export default class Plugins {
// refresh will cause yarn.lock to install dependencies, including devDeps
await this.refresh(c.root, {prod: false})
await this.add({type: 'link', name: c.name, root: c.root})
// if the plugin has typescript in devDeps, we will also compile it
if (c.pjson.devDependencies?.typescript) {
try {
await this.yarn.exec(['run', 'tsc', '-p', '.', '--incremental', '--skipLibCheck'], {cwd: path.resolve(p), verbose: this.verbose})
} catch {
this.debug('typescript compilation failed')
}
}
}

async add(plugin: Interfaces.PJSON.PluginTypes): Promise<void> {
Expand Down